[CPDNPQ-2142] Ensure job only runs once if state change not possible

app/jobs/statements/mark_as_paid_job.rb

@@ -2,6 +2,10 @@
 
 module Statements
   class MarkAsPaidJob < ApplicationJob
+    discard_on StandardError do |_job, exception|
+      Sentry.capture_exception(exception)
+    end
+
     def perform(statement_id:)
       return unless statement_id
 

spec/jobs/statements/mark_as_paid_job_spec.rb

@@ -2,54 +2,91 @@
 
 require "rails_helper"
 
-RSpec.describe Statements::MarkAsPaidJob do
+RSpec.describe Statements::MarkAsPaidJob, type: :job do
   subject(:job) { described_class.new.perform(statement_id:) }
 
   before do
     allow(Statements::MarkAsPaid).to receive(:new).with(statement).and_return(service)
     allow(service).to receive(:mark).and_return(true)
     allow(Rails.logger).to receive(:warn)
-
-    job
+    allow(Sentry).to receive(:capture_exception).and_return(true)
   end
 
   let(:service) { Statements::MarkAsPaid.new(statement) }
   let(:statement) { create(:statement, :payable) }
   let(:statement_id) { statement.id }
 
-  context "with correct params" do
-    context "when statement is payable" do
-      it "calls the correct service" do
-        expect(service).to have_received(:mark)
+  describe "#perform" do
+    before { job }
+
+    context "with correct params" do
+      context "when statement is payable" do
+        it "calls the correct service" do
+          expect(service).to have_received(:mark)
+        end
+      end
+
+      context "when statement is not payable" do
+        let(:statement) { create(:statement, :paid) }
+
+        it "does not call the service" do
+          expect(Statements::MarkAsPaid).not_to have_received(:new)
+        end
       end
     end
 
-    context "when statement is not payable" do
-      let(:statement) { create(:statement, :paid) }
+    context "with incorrect params" do
+      let(:statement_id) { SecureRandom.uuid }
 
       it "does not call the service" do
         expect(Statements::MarkAsPaid).not_to have_received(:new)
       end
+
+      it "logs a warning" do
+        expect(Rails.logger)
+          .to have_received(:warn)
+              .with("Statement could not be found - statement_id: #{statement_id}")
+      end
+    end
+
+    context "with no params" do
+      let(:statement_id) { nil }
+
+      it { is_expected.to be_nil }
     end
   end
 
-  context "with incorrect params" do
-    let(:statement_id) { SecureRandom.uuid }
+  describe "#perform_later" do
+    subject(:job) { described_class.perform_later(statement_id:) }
 
-    it "does not call the service" do
-      expect(Statements::MarkAsPaid).not_to have_received(:new)
+    it "enqueues the job exactly once" do
+      expect { job }.to have_enqueued_job(described_class).exactly(:once).on_queue("default")
     end
 
-    it "logs a warning" do
-      expect(Rails.logger)
-        .to have_received(:warn)
-            .with("Statement could not be found - statement_id: #{statement_id}")
+    context "with valid job" do
+      before do
+        perform_enqueued_jobs { job }
+      end
+
+      it { expect(Sentry).not_to have_received(:capture_exception) }
+      it { expect(Delayed::Job.count).to be_zero }
     end
-  end
 
-  context "with no params" do
-    let(:statement_id) { nil }
+    context "with invalid job" do
+      before do
+        allow(service).to receive(:mark).and_raise(exception)
 
-    it { is_expected.to be_nil }
+        perform_enqueued_jobs { job }
+      end
+
+      let :exception do
+        StateMachines::InvalidTransition.new(statement,
+                                             Statement.state_machines[:state],
+                                             :mark_paid)
+      end
+
+      it { expect(Sentry).to have_received(:capture_exception) }
+      it { expect(Delayed::Job.count).to be_zero }
+    end
   end
 end

spec/rails_helper.rb

@@ -142,6 +142,7 @@
     end
   end
 
+  config.include ActiveJob::TestHelper, type: :job
   config.include Helpers::JourneyHelper, type: :feature
   config.before(:each, type: :feature) do
     stub_env_variables_for_gai