[CPDNPQ-2419] Fix some flakey tests #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-2095-web.test.teacherservices.cloud/ |
|
jebw
reviewed
Dec 20, 2024
| @@ -20,7 +20,7 @@ | |||
| expect(page).to have_css("td:nth-child(1)", text: voided_declaration.id) | |||
| expect(page).to have_css("td:nth-child(2)", text: voided_declaration.user.id) | |||
| expect(page).to have_css("td:nth-child(3)", text: voided_declaration.declaration_type) | |||
| expect(page).to have_css("td:nth-child(4)", text: voided_declaration.course.name) | |||
| expect(page).to have_css("td:nth-child(4)", text: voided_declaration.reload.course.name) | |||
There was a problem hiding this comment.
If the declaration is needing to be reloaded, presumably because data may have changed, shouldn't the first usage of the declaration on line 20 be the one doing the reload?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2419
tl;dr: fix some flakey tests — think I got them all, but some of the failures are veeeery intermittent and can't be reliably reproduced even with the same seed! So we'll have to wait and see.