[CPDNPQ-2395] improve participants API load times #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-2101-web.test.teacherservices.cloud/ |
|
peteryates
reviewed
Jan 3, 2025
| @@ -10,7 +10,7 @@ module Pagination | |||
| private | |||
|
|
|||
| def paginate(scope) | |||
| _pagy, paginated_records = pagy(scope, limit: per_page, page:) | |||
| _pagy, paginated_records = pagy_countless(scope, limit: per_page, page:) | |||
alkesh
changed the title
jebw
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2395
requests to
/api/v3/participants/npq?page_size=3000&updated_since=2020-01-01are too slow (~800ms)Changes proposed in this pull request
Tested using a production data dump, using lead provider Ambition Institute, which has ~46,000 users.
before optimisation: page load ~800ms
after optimisation: page load ~150ms