Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDNPQ-2442] Default to running rails console from workers #2109

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Jan 7, 2025

Context

Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2442

Currently the default Makefile commands will run consoles on the web nodes which can impact a running web request if the console usage triggers an out of memory scenario.

A secondary concern is the console command by default provides read-write and in production this will often only need to be read-only for investigation purposes

Changes proposed in this pull request

  1. Run all commands from worker nodes instead
  2. Provide an alternative to ssh into a web node
  3. Changed the default aks-console to use rails' --sandbox parameter
  4. Added a new aks-rw-console command to run without the --sandbox parameter

@jebw jebw requested a review from a team as a code owner January 7, 2025 17:17
@jebw jebw changed the title [BAU] Default to running rails console from workers [CPDNPQ-2442] Default to running rails console from workers Jan 7, 2025
Makefile Show resolved Hide resolved
Copy link

github-actions bot commented Jan 7, 2025

@jebw jebw force-pushed the bau-run-console-from-workers branch from 11949c5 to f817c12 Compare January 7, 2025 17:29
Copy link

sonarqubecloud bot commented Jan 7, 2025

@jebw jebw added this pull request to the merge queue Jan 8, 2025
@jebw jebw removed this pull request from the merge queue due to a manual request Jan 8, 2025
@jebw jebw added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit c254df1 Jan 8, 2025
18 checks passed
@jebw jebw deleted the bau-run-console-from-workers branch January 8, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants