[CPDNPQ-2225] qualifications API for TRS - part of DQT decommissioning #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://npq-registration-review-2115-web.test.teacherservices.cloud/ |
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
27a3f2e to
063224b
Compare
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
063224b to
c1077ca
Compare
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
c1077ca to
ac39162
Compare
rwrrll
reviewed
Jan 15, 2025
db/migrate/20241105145235_create_legacy_passed_participant_outcomes.rb
Outdated
Show resolved
Hide resolved
spec/lib/tasks/one_off/load_legacy_participant_outcomes_spec.rb
Outdated
Show resolved
Hide resolved
spec/lib/tasks/one_off/load_legacy_participant_outcomes_spec.rb
Outdated
Show resolved
Hide resolved
jebw
reviewed
Jan 15, 2025
There was a problem hiding this comment.
LGTM - couple of comments around schema changes and API path
The actual API format makes me wince a little since this is what JSON:API has include and entity relationships for but it is following the pattern of our other APIs and does make it simpler to consume for someone just parsing as raw JSON (instead of using a JSON:API client)
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
ac39162 to
e3f16b4
Compare
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
e3f16b4 to
1db7239
Compare
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
9c30a2f to
4df55a8
Compare
…lt to using lead_provider scope
…th lead_provider scope
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
4df55a8 to
829188f
Compare
alkesh
force-pushed
the
CPDNPQ-2225-qualifications-api
branch
from
829188f to
a44338d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2225
Changes proposed in this pull request
scopeto APIToken - this is eitherlead_providerorteacher_record_service- and a token from one scope cannot access the APIs from the other scopedocs/qualifications_api.md)