[CPDNPQ-2435] Add "in review" applications screen #2142
Conversation
|
Review app deployed to https://npq-registration-review-2142-web.test.teacherservices.cloud/ |
|
|
||
| private | ||
|
|
||
| def employment_types |
There was a problem hiding this comment.
should this array be on the Application model?
There was a problem hiding this comment.
I think so, yes, but employment_type is a bit of a mess throughout the app with string checking all over the place... I feel like the correct solution is to formally define it as an enum or something once and for all and then tidy up all the corners of the app where it's used, but I'd prefer to do that as a separate ticket because it needs a bit of care and BA attention to do properly, whereas this ticket is needed for BAU in a few weeks I believe.
@jebw are you up for scheduling an employment_type clean up ticket, or would you prefer we hold up this ticket and roll it in now?
There was a problem hiding this comment.
Just to also mention here while it's in my mind, referred_by_return_to_teaching_adviser is a string that can be nil... it should probably be a NOT NULL boolean, that should also be captured for fixing at some point!
There was a problem hiding this comment.
@rwrrll Feel free to write a ticket - maybe schedule it for a couple of sprints time and we can evaluate in sprint review whether we have adequate capacity to do with it
Put it under uptime and maintenance epic, thanks
|
|
||
| def employment_types | ||
| %w[ | ||
| hospital_school |
There was a problem hiding this comment.
do we also need lead_mentor_for_accredited_itt_provider in this array?
There was a problem hiding this comment.
Yes, amazing catch, thanks! 🦅 👁️
rwrrll
force-pushed
the
2435-edge-case-applications
branch
from
6f5160a to
30be143
Compare
|
Context
Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2435
UCD prototype: https://npq-prototype.herokuapp.com/admin-v3/registrations-review
Screenshot of the new screen added by this PR: