forked from compdemocracy/polis
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE: #30 - Migrate client-admin to Webpack #31
Merged
brendanarnold
merged 9 commits into
govuk/main
from
govuk/bug/30-migrate-client-admin-to-webpack
Dec 11, 2022
Merged
ISSUE: #30 - Migrate client-admin to Webpack #31
brendanarnold
merged 9 commits into
govuk/main
from
govuk/bug/30-migrate-client-admin-to-webpack
Dec 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* First-pass gulp-to-webpack conversion. * Update webpack-cli, and create prod/dev logic. * Messy: leave uncompressed files in dev mode build. * Shut off compression in dev mode more elegantly. * Get docker build working. * Fixed bundlewatch path to find client-admin files. * Get rid of old webpack build scripts. * Don't minify for dev build. * Removed dep pkgs for s3 deploy. * Added ability to use bundle analyzer plugin. * Removed all unneeded files. * Fixed up eslint issue with upgraded packages. * Fixed bundlewatch CI script. * Keep new client-admin bundle consistently named. * Try running e2e tests against sslip.io instead of localhost. * Escape the domainWhitelist strings as it was done before. * Revert "Try running e2e tests against sslip.io instead of localhost." This reverts commit 46722d0. * Oops. Inversed the boolean for configs. * Trying to debug index_admin.html issue. * Added upterm for remote debugging. * Ensure upterm runs on failures. * Added publicPath to make script link absolute. * Drop the embed.html test file into new home. * Ensuring dev mode builds and dev server use same simplifications. * Set up all routes to point to index.html. Added mention of future proxy. * Removed debugging step from github actions. * Tiny fixups to clean up PR. * Only write headerJson files during prod build. * Migrate from dist to more build as before. * Removed unneeded config vars. * Cleaned up webpack dev-mode logic. * Went back to using dist folder to fix bundle-analyzer bug. * Updated client-admin README. Removed badges. Removed deployment references. * Cleaned up ignorefiles. * Mention where builds happen. * Use build instead of dist for client-admin build output * switch to npm run build:prod in file-server/Dockerfile * inject compiled js in html body for client-admin * add/update webpack versions Co-authored-by: Christopher Small <metasoarous@gmail.com>
* Adding farsi translation * Update client-participation/js/strings.js Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com> Co-authored-by: Colin Megill <colinmegill@gmail.com> Co-authored-by: Patrick Connolly <patrick.c.connolly@gmail.com>
* Bump node from 11.15.0-alpine to 18.9.0-alpine in /client-admin (compdemocracy#1523) Bumps node from 11.15.0-alpine to 18.9.0-alpine. --- updated-dependencies: - dependency-name: node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node from 11.15.0-alpine to 18.9.0-alpine in /client-report (compdemocracy#1525) Bumps node from 11.15.0-alpine to 18.9.0-alpine. --- updated-dependencies: - dependency-name: node dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump moment from 2.29.1 to 2.29.4 in /client-report (compdemocracy#1514) Bumps [moment](https://github.com/moment/moment) from 2.29.1 to 2.29.4. - [Release notes](https://github.com/moment/moment/releases) - [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md) - [Commits](moment/moment@2.29.1...2.29.4) --- updated-dependencies: - dependency-name: moment dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ws from 7.4.2 to 7.5.7 in /client-admin (compdemocracy#1395) Bumps [ws](https://github.com/websockets/ws) from 7.4.2 to 7.5.7. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.4.2...7.5.7) --- updated-dependencies: - dependency-name: ws dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump got and nodemon in /server (compdemocracy#1539) Removes [got](https://github.com/sindresorhus/got). It's no longer used after updating ancestor dependency [nodemon](https://github.com/remy/nodemon). These dependencies need to be updated together. Removes `got` Updates `nodemon` from 2.0.7 to 2.0.20 - [Release notes](https://github.com/remy/nodemon/releases) - [Commits](remy/nodemon@v2.0.7...v2.0.20) --- updated-dependencies: - dependency-name: got dependency-type: indirect - dependency-name: nodemon dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump y18n from 3.2.1 to 3.2.2 in /client-report (compdemocracy#932) Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump minimist from 1.2.5 to 1.2.6 in /client-admin (compdemocracy#1384) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update de_de.js Checked german language (native speaker). Corrected some inconsistencies and grammar errors. * Update de_de.js * Update de_de.js * Revert "Bump node from 11.15.0-alpine to 18.9.0-alpine in /client-admin (compdemocracy#1523)" This reverts commit 0d1242f. * Revert "Bump node from 11.15.0-alpine to 18.9.0-alpine in /client-report (compdemocracy#1525)" This reverts commit 54ed279. * Revert "Bump moment from 2.29.1 to 2.29.4 in /client-report (compdemocracy#1514)" This reverts commit 4e7dd51. * Revert "Bump ws from 7.4.2 to 7.5.7 in /client-admin (compdemocracy#1395)" This reverts commit 0224f8e. * Revert "Bump got and nodemon in /server (compdemocracy#1539)" This reverts commit 0c18e1e. * Revert "Bump minimist from 1.2.5 to 1.2.6 in /client-admin (compdemocracy#1384)" This reverts commit 0e8263b. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christopher Small <metasoarous@gmail.com>
…-client-admin-to-webpack
brendanarnold
changed the title
ISSUE:#30 - Migrate client-admin to Webpack
ISSUE: #30 - Migrate client-admin to Webpack
Jan 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #30
client-admin