Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log DfE analytics events #4707

Conversation

tomas-stefano
Copy link
Contributor

Context

We do not need to send all of DfE analytics to our logs.

Changes proposed in this pull request

Do not log DfE analytics.

Guidance to review

  1. Does logit on this review app logging DfE analytics?

@tomas-stefano tomas-stefano added the deploy A Review App will be created for PRs with this label label Nov 21, 2024
@tomas-stefano tomas-stefano requested a review from a team as a code owner November 21, 2024 13:38
@tomas-stefano
Copy link
Contributor Author

Copy link
Contributor

@gms-gs gms-gs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomas-stefano tomas-stefano merged commit 91709d0 into main Nov 22, 2024
38 checks passed
@tomas-stefano tomas-stefano deleted the td/25-publish-remove-dfe-analytic-logs-from-semantic-logger branch November 22, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants