Stop pre-loading accredited course list associations #4708
Merged
+86
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitemaeric
force-pushed
the
dd/optimise-accredited-course-list-export
branch
from
566c4d2
to
d89e977
Compare
Pre-loading the accredited course list associations slows down the entire response time by 10x. This is likely due to ineffective indexes - To be investigated further.
Nitemaeric
force-pushed
the
dd/optimise-accredited-course-list-export
branch
3 times, most recently
from
cbf3d15
to
2640668
Compare
`after_save :update_program_type!` sets the program type after the record has been saved to the database. This doesn't update the database record unless it is saved again.
Nitemaeric
force-pushed
the
dd/optimise-accredited-course-list-export
branch
from
2640668
to
b6b7042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The accredited provider's download of all courses they ratify times out for some providers. We need to investigate the cause and how to fix it.
Changes proposed in this pull request
.includescall when loading the accredited course list. More information in commit message: 137a46espec/services/exports/accredited_course_list_spec.rbspec, it would failcourse.program_type == course.program_type. This is because one of the instances was taken from the database, one ran the after_save callback.Guidance to review