Rename the accredited_provider_id column #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
force-pushed
the
im/267-tech-debt-rename-the-accreditedproviderid-column
branch
3 times, most recently
from
798e734
to
8ba9e69
Compare
inulty-dfe
added
deploy
Nitemaeric
approved these changes
Nov 27, 2024
Yeah I was also confused by it's existence. It's a param in the |
inulty-dfe
force-pushed
the
im/267-tech-debt-rename-the-accreditedproviderid-column
branch
from
7f190c0
to
a465d8c
Compare
The AccreditedProvidersController still uses a param called `accredited_provdier_id`. It is unrelated to the accredited_provider_number
inulty-dfe
force-pushed
the
im/267-tech-debt-rename-the-accreditedproviderid-column
branch
from
a465d8c
to
843da5d
Compare
inulty-dfe
deleted the
im/267-tech-debt-rename-the-accreditedproviderid-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Provider model has a column named
accredited_provider_id.The value represents an identifier used by Funding and Market Regs to discriminate between providers with similar names and such.
_idsuffixes in Ruby on Rails conventionally denote a foreign key columns on the model.We're changing this column name to avoid obvious misunderstandings.
Changes proposed in this pull request
Rename
accredited_provider_idcolumn toaccredited_provider_numberGuidance to review