Feat: Vertical navigation changes and bug fixes #70
ThomasWhittingtoncode-pr-check.yml
on: pull_request
Build and run unit tests
1m 49s
Annotations
10 warnings
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Controllers/SitemapController.cs#L10
Change the paths of the actions of this controller to be relative and adapt the controller route accordingly. (https://rules.sonarsource.com/csharp/RSPEC-6931)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Views/Shared/RichText/_Vimeo.cshtml#L4
Indexing at Count-1 should be used instead of the "Enumerable" extension method "Last" (https://rules.sonarsource.com/csharp/RSPEC-6608)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Views/Shared/RichText/Custom/_Card.cshtml#L13
Remove the unnecessary Boolean literal(s). (https://rules.sonarsource.com/csharp/RSPEC-1125)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Views/Shared/RichText/Custom/_Card.cshtml#L17
Remove the unnecessary Boolean literal(s). (https://rules.sonarsource.com/csharp/RSPEC-1125)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Views/Shared/RichText/Custom/_Attachment.cshtml#L9
Indexing at Count-1 should be used instead of the "Enumerable" extension method "Last" (https://rules.sonarsource.com/csharp/RSPEC-6608)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Services/LayoutService.cs#L63
Make 'GetVisiblePageList' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
|
Build and run unit tests:
src/Dfe.ContentSupport.Web/Services/LayoutService.cs#L73
Make 'GetNavigationUrl' a static method. (https://rules.sonarsource.com/csharp/RSPEC-2325)
|
|
Build and run unit tests:
tests/Dfe.ContentSupport.Web.Tests/Models/Mapped/Custom/CustomAccordionTests.cs#L50
Cannot convert null literal to non-nullable reference type.
|
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
code-coverage-report
|
6.6 KB |
|