Feat: now using keyed services #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Iain-Stanger
approved these changes
Oct 7, 2024
ThomasWhittington
added a commit
that referenced
this pull request
Oct 7, 2024
* feat: changed header logo to go to self-assessment (#153) Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * Fix/bleeding links (#154) * fix: feedback link fixed * Fix: Fixed bleeding links --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * fix: added missing span from feedback banner * chore: Simplify hiding js-only elements * feature: setup to use plantechs head and cookies when ran with it (#156) * feature: setup to use plantechs head and cookies when ran with it * fix: added a title to the gtm iframe * chore: using index reference rather than .First --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * docs: added basic readme file (#160) * docs: added basic readme file * docs: added testing instruction to README.md --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * Fix: fixed contentful fail on first attempt (#159) * Using plantech contentful connection * chore: cleaned up contentful reshuffle --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * feat: vertical navigation changes (#161) * feat: made urls use new slug value instead of internal name * chore: cleanedup lint issues * chore: linter issue * fix: updated tests for slug change * fix: updated tests for slug change * feat: now uses csPage heading when no page available or when new useParentHero option is selected in contentful * feat: added unsupported element when item type isn't recognised * Removed tests for removed endpoints * Update src/Dfe.ContentSupport.Web/Views/Shared/_VerticalNavigation.cshtml Co-authored-by: jimwashbrook <131891854+jimwashbrook@users.noreply.github.com> * chore: fixed formatting in test * chore: removed redundant case * changes method back to not static and removed Privacy.cshtml --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> Co-authored-by: jimwashbrook <131891854+jimwashbrook@users.noreply.github.com> * remove unnused variables from cypress config * "Bits and Bats". Required changes for plantech integration (#158) (#165) * feat: changed header logo to go to self-assessment (#153) * Fix/bleeding links (#154) * fix: feedback link fixed * Fix: Fixed bleeding links --------- * fix: added missing span from feedback banner * feature: setup to use plantechs head and cookies when ran with it (#156) * feature: setup to use plantechs head and cookies when ran with it * fix: added a title to the gtm iframe * chore: using index reference rather than .First --------- --------- Co-authored-by: jimwashbrook <131891854+jimwashbrook@users.noreply.github.com> Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> * Feat: now using keyed services (#167) * Feat: now using keyed services * chore: ran cleanup on new code --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> --------- Co-authored-by: Tom Whittington <tom.whittington@education.gov.uk> Co-authored-by: katie-gardner-AND <katharine.gardner@and.digital> Co-authored-by: jimwashbrook <131891854+jimwashbrook@users.noreply.github.com> Co-authored-by: jack.coggin <jack.coggin@and.digital> Co-authored-by: Katie Gardner <114991656+katie-gardner@users.noreply.github.com> Co-authored-by: jack-coggin <119428483+jack-coggin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the critical services be keyed so that it shouldn't clash with PT anymore. I've locally hooked it up to PT and it seems to be working as expected