Skip to content

fix: Handle IContentComponent serialisation + Redis errors better #3512

fix: Handle IContentComponent serialisation + Redis errors better

fix: Handle IContentComponent serialisation + Redis errors better #3512

Triggered via pull request November 22, 2024 16:25
Status Success
Total duration 5m 49s
Artifacts 1

code-pr-check.yml

on: pull_request
Lint & Commit
56s
Lint & Commit
Build database upgrader
22s
Build database upgrader
Run javascript tests
15s
Run javascript tests
Build and run unit tests
2m 53s
Build and run unit tests
Fit to window
Zoom out
Zoom in

Annotations

12 warnings
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Questionnaire/Queries/GetSectionQueryTests.cs#L59
Argument of type 'Task<IEnumerable<Section>?>' cannot be used for parameter 'value' of type 'Task<IEnumerable<Section>>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<IEnumerable<Section>>>(Task<IEnumerable<Section>> value, Func<CallInfo, Task<IEnumerable<Section>>> returnThis, params Func<CallInfo, Task<IEnumerable<Section>>>[] returnThese)' due to differences in the nullability of reference types.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetSubTopicRecommendationQueryTests.cs#L139
Argument of type 'Task<IEnumerable<SubtopicRecommendation>?>' cannot be used for parameter 'value' of type 'Task<IEnumerable<SubtopicRecommendation>>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<IEnumerable<SubtopicRecommendation>>>(Task<IEnumerable<SubtopicRecommendation>> value, Func<CallInfo, Task<IEnumerable<SubtopicRecommendation>>> returnThis, params Func<CallInfo, Task<IEnumerable<SubtopicRecommendation>>>[] returnThese)' due to differences in the nullability of reference types.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetEntityFromContentfulQueryTests.cs#L24
Argument of type 'Task<Question?>' cannot be used for parameter 'value' of type 'Task<Question>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<Question>>(Task<Question> value, Func<CallInfo, Task<Question>> returnThis, params Func<CallInfo, Task<Question>>[] returnThese)' due to differences in the nullability of reference types.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L54
Argument of type 'Task<IEnumerable<Page>?>' cannot be used for parameter 'value' of type 'Task<IEnumerable<Page>>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<IEnumerable<Page>>>(Task<IEnumerable<Page>> value, Func<CallInfo, Task<IEnumerable<Page>>> returnThis, params Func<CallInfo, Task<IEnumerable<Page>>>[] returnThese)' due to differences in the nullability of reference types.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetNavigationQueryTests.cs#L29
Argument of type 'Task<IEnumerable<NavigationLink>?>' cannot be used for parameter 'value' of type 'Task<IEnumerable<NavigationLink>>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<IEnumerable<NavigationLink>>>(Task<IEnumerable<NavigationLink>> value, Func<CallInfo, Task<IEnumerable<NavigationLink>>> returnThis, params Func<CallInfo, Task<IEnumerable<NavigationLink>>>[] returnThese)' due to differences in the nullability of reference types.
Build and run unit tests: src/Dfe.PlanTech.Web/Controllers/PagesController.cs#L47
Possible null reference argument for parameter 'contentId' in 'Task<NavigationLink?> IGetEntityFromContentfulQuery.GetEntityById<NavigationLink>(string contentId, CancellationToken cancellationToken = default(CancellationToken))'.
Build and run unit tests: src/Dfe.PlanTech.Web/Controllers/PagesController.cs#L61
Possible null reference argument for parameter 'contentId' in 'Task<NavigationLink?> IGetEntityFromContentfulQuery.GetEntityById<NavigationLink>(string contentId, CancellationToken cancellationToken = default(CancellationToken))'.
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
Build and run unit tests: tests/Dfe.PlanTech.Application.UnitTests/Questionnaire/Queries/GetSectionQueryTests.cs#L59
Argument of type 'Task<IEnumerable<Section>?>' cannot be used for parameter 'value' of type 'Task<IEnumerable<Section>>' in 'ConfiguredCall SubstituteExtensions.Returns<Task<IEnumerable<Section>>>(Task<IEnumerable<Section>> value, Func<CallInfo, Task<IEnumerable<Section>>> returnThis, params Func<CallInfo, Task<IEnumerable<Section>>>[] returnThese)' due to differences in the nullability of reference types.

Artifacts

Produced during runtime
Name Size
code-coverage-report
57.9 KB