fix: Fix sonar cloud errors

DFE-Digital · Dec 9, 2024 · 7c5c95f · 7c5c95f
1 parent 8b0e2bb
commit 7c5c95f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/Dfe.PlanTech.Web/Controllers/PagesController.cs b/src/Dfe.PlanTech.Web/Controllers/PagesController.cs
@@ -18,13 +18,11 @@ namespace Dfe.PlanTech.Web.Controllers;
 [Route("/")]
 public class PagesController(
     ILogger<PagesController> logger,
-    IGetPageQuery getPageQuery,
     IGetNavigationQuery getNavigationQuery,
     IOptions<ContactOptions> contactOptions,
     IOptions<ErrorPages> errorPages) : BaseController<PagesController>(logger)
 {
     private readonly ContactOptions _contactOptions = contactOptions.Value;
-    private readonly ErrorPages _errorPages = errorPages.Value;
     public const string ControllerName = "Pages";
     public const string GetPageByRouteAction = nameof(GetByRoute);
     public const string NotFoundPage = "NotFoundError";
@@ -66,7 +64,7 @@ public async Task<IActionResult> NotFoundError()
         return View(viewModel);
     }
 
-    private async Task<INavigationLink> GetContactLinkAsync()
+    private async Task<INavigationLink?> GetContactLinkAsync()
     {
         return await getNavigationQuery.GetLinkById(_contactOptions.LinkId);
     }

diff --git a/tests/Dfe.PlanTech.Web.UnitTests/Controllers/PagesControllerTests.cs b/tests/Dfe.PlanTech.Web.UnitTests/Controllers/PagesControllerTests.cs
@@ -28,7 +28,6 @@ public class PagesControllerTests
         readonly ICookieService cookiesSubstitute = Substitute.For<ICookieService>();
         readonly IUser userSubstitute = Substitute.For<IUser>();
         private readonly IGetNavigationQuery _getNavigationQuery = Substitute.For<IGetNavigationQuery>();
-        private readonly IGetPageQuery _getPageQuery = Substitute.For<IGetPageQuery>();
         private readonly PagesController _controller;
         private readonly ControllerContext _controllerContext;
         private readonly IOptions<ContactOptions> _contactOptions;
@@ -48,7 +47,7 @@ public PagesControllerTests()
             _contactOptions = Options.Create(contactUs);
             _errorPages = Options.Create(new ErrorPages { InternalErrorPageId = INTERNAL_ERROR_ID });
 
-            _controller = new PagesController(Logger, _getPageQuery, _getNavigationQuery, _contactOptions, _errorPages)
+            _controller = new PagesController(Logger, _getNavigationQuery, _contactOptions, _errorPages)
             {
                 ControllerContext = _controllerContext,
                 TempData = Substitute.For<ITempDataDictionary>()