Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tf): Correct Azure Client ID #847

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

jimwashbrook
Copy link
Collaborator

Overview

Addresses ticket 234276

Adds AZURE_CLIENT_ID back to the container app environment variables, this time with the correct value.

Note: this is dependant on this PR in the DFE TF module. Which has not gone in yet.

Changes

Minor

  • Set AZURE_CLIENT_ID environment variable on the container app
  • Increment module version

Checklist

Delete any rows that do not apply to the PR.

  • Title uses Angular commit convention
  • PR targets development branch
  • Unit tests have been added/updated
  • E2E tests have been added/updated
  • GitHub workflows/actions have been added/updated
  • Terraform has been updated
  • Documentation has been updated where relevant
  • Any Key Vault secrets have been added to the development Key Vault

Copy link
Contributor

github-actions bot commented Nov 11, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output


Warnings:

- Argument is deprecated
  on providers.tf line 4
- Attribute Deprecated
  on providers.tf line 4

To see the full warning notes, run Terraform without -compact-warnings.
Success! The configuration is valid, but there were some validation warnings
as shown above.


Terraform Plan 📖success

Pusher: @jimwashbrook, Action: pull_request, Working Directory: terraform/container-app, Workflow: Terraform PR Check

gitbutler-client and others added 2 commits November 11, 2024 10:36
This is a merge commit the virtual branches in your workspace.

Due to GitButler managing multiple virtual branches, you cannot switch back and
forth between git branches and virtual branches easily. 

If you switch to another branch, GitButler will need to be reinitialized.
If you commit on this branch, GitButler will throw it away.

Here are the branches that are currently applied:
 - development (refs/gitbutler/development)
   branch head: e137035
For more information about what we're doing here, check out our docs:
https://docs.gitbutler.com/features/virtual-branches/integration-branch
chore: update module ref

chore: formatting

terraform-docs: automated action
@jimwashbrook jimwashbrook merged commit a07749f into development Nov 11, 2024
4 checks passed
@jimwashbrook jimwashbrook deleted the fix/234276-tf/azure-client-id branch November 11, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants