Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add redirect of landing page to terraform #850

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

katie-gardner
Copy link
Collaborator

@katie-gardner katie-gardner commented Oct 29, 2024

Overview

Addresses ticket #234508

Adds the url redirect to terraform as a configuration option per environment
Depends on a PR for the waf module
Also depends on Jims PR for the client id

Changes

  • Adds a new variable for specifying any url redirects

How to review the PR

To test this locally, you can update your terraform-dev.tfvars to include

cdn_frontdoor_url_path_redirects = [
  {
    "redirect_type" : "PermanentRedirect",
    "redirect_protocol" : "Https"
    "destination_path" : "/guidance/plan-technology-for-your-school",
    "destination_hostname" : "www.gov.uk",
    "operator" : "Equal",
    "match_values" : ["/"],
  }
]

and then look at the plan/apply for the waf module
terraform plan -var-file=terraform-${TERRAFORM_ENVIRONMENT}.tfvars -target=module.waf

From running this, in the Azure portal front door a new rule set should have been added called s190d01plantechurlpathredirects which has the exact same redirect that we have in production, but for dev instead, and the dev homepage should start being redirected to the guidance page

Release requirements

The above config just needs adding to the prod tfvars in the keyvault

Checklist

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Terraform Format and Style 🖌success

Terraform Initialization ⚙️success

Terraform Validation 🤖success

Validation Output


Warnings:

- Argument is deprecated
  on providers.tf line 4
- Attribute Deprecated
  on providers.tf line 4

To see the full warning notes, run Terraform without -compact-warnings.
Success! The configuration is valid, but there were some validation warnings
as shown above.


Terraform Plan 📖success

Pusher: @katie-gardner, Action: pull_request, Working Directory: terraform/container-app, Workflow: Terraform PR Check

@jimwashbrook jimwashbrook self-requested a review October 30, 2024 08:57
Copy link
Collaborator

@jimwashbrook jimwashbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@katie-gardner katie-gardner force-pushed the fix/234508/landing-page-redirect-tf branch from 73a3e30 to aff87ff Compare November 11, 2024 10:26
@katie-gardner katie-gardner merged commit 3eaa9c5 into development Nov 11, 2024
4 checks passed
@katie-gardner katie-gardner deleted the fix/234508/landing-page-redirect-tf branch November 11, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants