Review work history gaps #7347
Open
Review work history gaps #7347
+135
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddippolito
force-pushed
the
review-work-history-gaps
branch
from
7d9cee7 to
25864a1
Compare
ddippolito
force-pushed
the
review-work-history-gaps
branch
from
25864a1 to
6786a8f
Compare
|
Review app deployed to https://teaching-vacancies-review-pr-7347.test.teacherservices.cloud on AKS |
starswan
reviewed
Dec 12, 2024
Comment on lines
57
to
64
| attributes[:unexplained_employment_gaps] = job_application.unexplained_employment_gaps if step == :employment_history | ||
|
|
||
| if step == :professional_status | ||
| attributes.merge(jobseeker_profile_attributes) | ||
| .merge(trn_params) | ||
| else | ||
| attributes | ||
| attributes.merge!(jobseeker_profile_attributes) | ||
| .merge!(trn_params) | ||
| end | ||
|
|
||
| attributes |
There was a problem hiding this comment.
IMHO it's bad practice for a function to modify its input parameters, hence the original non-destructive version
starswan
reviewed
Dec 12, 2024
| @@ -1,21 +1,25 @@ | |||
| class Jobseekers::JobApplication::EmploymentHistoryForm < Jobseekers::JobApplication::BaseForm | |||
| include ActiveModel::Model | |||
| include ActionView::Helpers::DateHelper | |||
There was a problem hiding this comment.
this feels like view code in the model layer. It would be more idiomatic to add an error which is then rendered later?
There was a problem hiding this comment.
I need access to distance_of_time_in_words; hence, I need to add this here. Also, consider this is a form model.
starswan
reviewed
Dec 12, 2024
|
|
||
| context "when employment history gaps are present" do | ||
| it "adds errors for each unexplained gap" do | ||
| form.valid? |
There was a problem hiding this comment.
the idiom here to to assert that the form isn't valid, which then allows the errors to be asserted afterwards rather than this hanging valid? call
starswan
reviewed
Dec 12, 2024
| let(:unexplained_employment_gaps_present) { "false" } | ||
|
|
||
| it "does not add errors for gaps" do | ||
| form.valid? |
starswan
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/EoVximLZ/1436-review-work-history-gaps-and-link-error-messaging-to-each-gap
Changes in this PR:
Split error messages in the working history gaps page.
Screenshots of UI changes:
Before
After