Instrument research #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job type is no longer used, because instruments are now crafted individually. Depends on dfhack commit e4de341 for plugin compilation.
I haven't analyzed the structure of the items in default_improvements, except that they definitely aren't stl-strings.
| <stl-string name="unk_v4201_1" comment='v0.42.01'/> | ||
| <stl-vector name="unk_v4201_2" comment='v0.42.01'/> | ||
| <stl-string name="description" comment='v0.42.01'/> | ||
| <stl-vector name="default_improvements" comment='v0.42.01'/> |
There was a problem hiding this comment.
Do you know what these contain? I think these might end up being vector<void*>s.
|
The description field is a simple string. |
|
Oh, I misread those and thought they were both vectors. Thanks! I'll try looking into the layout of default_improvements when I have time, although it shouldn't prevent merging this (once other stuff with .02/.03 is cleaned up). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MakeInstrument is no longer a supported job type, and there are new tags allowed in raws for tools.
Depends on DFHack/dfhack#770 for plugin compilation.