Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stockpiles.lua to add functionality to import/export that was a work in progress before modification. #5000

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

unboundlopez
Copy link

Added functionality to import export on the stockpile menu.

Added functionality to import export on the stockpile menu.
@unboundlopez
Copy link
Author

pre-commit.ci autofix

@unboundlopez
Copy link
Author

Dwarf.Fortress.2024.10.13-12.24.mp4

@chdoc
Copy link
Member

chdoc commented Oct 13, 2024

@myk002 Could you provide some context on 856237c (Part of #3285)

It looks to me like the functionality provided by this PR was already partially implemented, but commented out, beforehand.

@ab9rf
Copy link
Member

ab9rf commented Oct 31, 2024

Please give this PR a more descriptive name than "update stockpiles.lua". We often depend on being able to review code history to understand why code is the way it is, and commits and PRs with nondescript titles and descriptions are not helpful to this end.

@unboundlopez unboundlopez changed the title Update stockpiles.lua Update stockpiles.lua to add functionality to import/export that was a work in progress before modification. Oct 31, 2024
@unboundlopez
Copy link
Author

Updated the title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

3 participants