Workaround for subset failure #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
htmlboss
commented
May 27, 2019
htmlboss
commented
- Described here: to_netcdf() fails to write if input is read from netcdf3_classic pydata/xarray#2822 (comment)
- Until we get our conda environment fixed this will have to do.
* Described here: pydata/xarray#2822 (comment) * Until we get our conda environment fixed this will have to do.
halehkh65
added a commit
that referenced
this pull request
May 27, 2019
* WIP: Implementing geojson-vt for bathymetry * Minor change to how geojson is loaded * Added API extension for PBF tiles * Updated API script * Disabled vector rendering before zoom level 7 * Added shape layers for zooms past 7 * Removed old API extension * Fixed Data types in bath_shapes params * Fixed extension of bath_shapes route * Changed API call for high res bathymetry to v1.0 * Disable old tiles for zooms beyond 7 * Chagned directory names to facilitate two demos * Updated max zoom level * disabled preloading on shape layers * Removed preloading, updated API to use mbtiles file * Moved tile serving to routes_impl and combined requests * removed demo stuff * Renamed API request and changed directories to work with flask config * Fixed styles, added projection to API request preemptively * Added projection variable + Added documentation * Vector sources now refresh on state change * Added description of mbt_impl * Formatting * Removed unnecessary files - deleted geojsons from previous attempts * Removed unnecessary lines * Added shape path - forgot this was important * Disabled preloading past zoom level 7 - exactly the same as having preloading at infinity for max zoom level 8 - this helps performance at higher zoom levels on lower end machines * Small clean up - changed layer_bath url back to the old api so old caches still work * Ran eslint --ext .jsx,.js src/ --fix * Unified tileGrids - Defined as a variable - Now using MAX_ZOOM[this.props.state.projection] * Fix some incorrect file paths * Changed variable names - Made mbt_imp a bit clearer * If block optimization - code more likely to run now runs first * Update datasetconfig.json (#429) * Added new calculated variables to supported datasets. * Switch from navigator domain to localhost (much better performance). * Workaround for subset failure (#433) * Described here: pydata/xarray#2822 (comment) * Until we get our conda environment fixed this will have to do. * Lat / Lon variable fix for subsetting (#434) * Search the superset for lat lon variables - broke from geoff's code, this should fix it * Removed unused variable declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.