Achievement cleanup #1529
Merged
Achievement cleanup #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exalted reputation achievements
gbrage
requested changes
Dec 1, 2023
gbrage
previously requested changes
Dec 1, 2023
.contrib/Parser/DATAS/01 - Dungeons Raids/03 - Wrath of the Lich King/0.5 - Achievements.lua
Outdated
Show resolved
Hide resolved
…tions + some style stuff
…t wide achievements rather than in their main hub
…en to its own file
…moved to the raids where they belong
|
All so far is looking well, but wanna make sure that the main list reflect to the change for new Achievement layout/code, etc.. cuz i pull from git daily (i love reporting errors if i see one lol).. My achievement says 100% even tho with pop out says otherwise... |
Myrhial
dismissed
gbrage’s stale review
Received permission via Discord DM to merge, so this can be checked on main in time for release
@vandiel01 Latest Git should show correctly for you, correct? |
|
yup so far! and thanks to you all for you do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved everything that was sourced into the achievement category to somewhere else in the addon so that section is finally its fully intended dynamic self. Open to feedback on where I've moved things. Else this will be merged in after a release, to allow some "live" review time by all contribs.