code style

DGP-Studio · Dec 8, 2024 · ea14b5e · ea14b5e
1 parent 7f10c81
commit ea14b5e
Show file tree

Hide file tree

Showing 10 changed files with 25 additions and 26 deletions.
diff --git a/src/Snap.Hutao/Snap.Hutao/Core/Database/ObservableReorderableDbCollection.cs b/src/Snap.Hutao/Snap.Hutao/Core/Database/ObservableReorderableDbCollection.cs
@@ -40,8 +40,7 @@ private static List<TEntity> AdjustIndex(List<TEntity> list)
         Span<TEntity> span = CollectionsMarshal.AsSpan(list);
         for (int i = 0; i < span.Length; i++)
         {
-            ref readonly TEntity item = ref span[i];
-            item.Index = i;
+            span[i].Index = i;
         }
 
         return list;
@@ -89,8 +88,7 @@ private static List<TEntityAccess> AdjustIndex(List<TEntityAccess> list)
         Span<TEntityAccess> span = CollectionsMarshal.AsSpan(list);
         for (int i = 0; i < span.Length; i++)
         {
-            ref readonly TEntityAccess item = ref span[i];
-            item.Entity.Index = i;
+            span[i].Entity.Index = i;
         }
 
         return list;

diff --git a/src/Snap.Hutao/Snap.Hutao/Core/DependencyInjection/Abstraction/OverseaSupportFactory.cs b/src/Snap.Hutao/Snap.Hutao/Core/DependencyInjection/Abstraction/OverseaSupportFactory.cs
@@ -4,17 +4,17 @@
 namespace Snap.Hutao.Core.DependencyInjection.Abstraction;
 
 [ConstructorGenerated]
-internal abstract partial class OverseaSupportFactory<TClient, TClientCN, TClientOS> : IOverseaSupportFactory<TClient>
+internal abstract partial class OverseaSupportFactory<TClient, TClientCn, TClientOs> : IOverseaSupportFactory<TClient>
     where TClient : notnull
-    where TClientCN : TClient
-    where TClientOS : TClient
+    where TClientCn : TClient
+    where TClientOs : TClient
 {
     private readonly IServiceProvider serviceProvider;
 
     public TClient Create(bool isOversea)
     {
         return isOversea
-            ? serviceProvider.GetRequiredService<TClientOS>()
-            : serviceProvider.GetRequiredService<TClientCN>();
+            ? serviceProvider.GetRequiredService<TClientOs>()
+            : serviceProvider.GetRequiredService<TClientCn>();
     }
 }
diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Proxy/HttpProxyUsingSystemProxy.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Proxy/HttpProxyUsingSystemProxy.cs
@@ -85,17 +85,6 @@ public void Dispose()
         (InnerProxy as IDisposable)?.Dispose();
     }
 
-    public void OnSystemProxySettingsChanged()
-    {
-        UpdateInnerProxy();
-
-        Debug.Assert(XamlApplicationLifetime.IsDispatcherQueueInitialized, "DispatcherQueue not initialized");
-        // TaskContext can't be injected directly, we have to retrieve it from the service provider after
-        ITaskContext taskContext = serviceProvider.GetRequiredService<ITaskContext>();
-        taskContext.BeginInvokeOnMainThread(() => OnPropertyChanged(nameof(CurrentProxyUri)));
-    }
-
-    [Command("EnableLoopbackCommand")]
     public void EnableLoopback()
     {
         loopbackSupport.EnableLoopback();
@@ -120,4 +109,15 @@ private void UpdateInnerProxy()
 
         InnerProxy = proxy;
     }
+
+    private void OnSystemProxySettingsChanged()
+    {
+        UpdateInnerProxy();
+
+        Debug.Assert(XamlApplicationLifetime.IsDispatcherQueueInitialized, "DispatcherQueue not initialized");
+
+        // TaskContext can't be injected directly, we have to retrieve it from the service provider after
+        ITaskContext taskContext = serviceProvider.GetRequiredService<ITaskContext>();
+        taskContext.BeginInvokeOnMainThread(() => OnPropertyChanged(nameof(CurrentProxyUri)));
+    }
 }
diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/AsyncHttpShards.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/AsyncHttpShards.cs
@@ -6,6 +6,7 @@
 
 namespace Snap.Hutao.Core.IO.Http.Sharding;
 
+[Obsolete("Dangerous to use")]
 [DebuggerTypeProxy(typeof(HttpShardsDebugView))]
 internal sealed class AsyncHttpShards : IAsyncEnumerable<IHttpShard>
 {

diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/HttpShardCopyWorker.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/HttpShardCopyWorker.cs
@@ -9,6 +9,7 @@
 
 namespace Snap.Hutao.Core.IO.Http.Sharding;
 
+[Obsolete("Dangerous to use")]
 internal static class HttpShardCopyWorker
 {
     public static async ValueTask<IHttpShardCopyWorker<TStatus>> CreateAsync<TStatus>(HttpShardCopyWorkerOptions<TStatus> options)
@@ -18,6 +19,7 @@ public static async ValueTask<IHttpShardCopyWorker<TStatus>> CreateAsync<TStatus
     }
 }
 
+[Obsolete("Dangerous to use")]
 [SuppressMessage("", "SA1402")]
 internal sealed partial class HttpShardCopyWorker<TStatus> : IHttpShardCopyWorker<TStatus>
 {

diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/HttpShardCopyWorkerOptions.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/HttpShardCopyWorkerOptions.cs
@@ -8,6 +8,7 @@
 
 namespace Snap.Hutao.Core.IO.Http.Sharding;
 
+[Obsolete("Dangerous to use")]
 internal sealed class HttpShardCopyWorkerOptions<TStatus>
 {
     private readonly LazySlim<SafeFileHandle> lazyDestinationFileHandle;

diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/IHttpShard.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/IHttpShard.cs
@@ -3,6 +3,7 @@
 
 namespace Snap.Hutao.Core.IO.Http.Sharding;
 
+[Obsolete("Dangerous to use")]
 internal interface IHttpShard
 {
     long Start { get; }

diff --git a/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/IHttpShardCopyWorker.cs b/src/Snap.Hutao/Snap.Hutao/Core/IO/Http/Sharding/IHttpShardCopyWorker.cs
@@ -3,6 +3,7 @@
 
 namespace Snap.Hutao.Core.IO.Http.Sharding;
 
+[Obsolete("Dangerous to use")]
 internal interface IHttpShardCopyWorker<out TStatus> : IDisposable
 {
     [SuppressMessage("", "SH003")]

diff --git a/src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Dialog/HutaoPassportRegisterDialog.xaml b/src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Dialog/HutaoPassportRegisterDialog.xaml
@@ -35,7 +35,7 @@
             MaxWidth="360"
             Margin="0,16,0,0"
             IsEnabled="{x:Bind VerifyCode, Converter={StaticResource StringBoolConverter}, Mode=OneWay}"
-            Password="{x:Bind Password, Mode=TwoWay}"
+            Password="{x:Bind Password, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"
             PasswordChar="*"
             PlaceholderText="{shuxm:ResourceString Name=ViewPageHutaoPassportPasswordHint}"/>
         <TextBlock

diff --git a/src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Page/TestPage.xaml b/src/Snap.Hutao/Snap.Hutao/UI/Xaml/View/Page/TestPage.xaml
@@ -174,11 +174,6 @@
                     Header="Check path belongs to a SSD"
                     IsClickEnabled="True"/>
 
-                <cwc:SettingsCard
-                    Command="{Binding TestHttpShardDownload}"
-                    Header="Http Shard Test"
-                    IsClickEnabled="True"/>
-
                 <cwc:SettingsCard
                     Command="{Binding RunCodeCommand}"
                     Header="Run Script Code"