Feature/extra attachments #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdoStorm96
approved these changes
Nov 6, 2024
| @@ -22,6 +28,12 @@ <h3> | |||
| {% for slot in slots %} | |||
| {% include slot with manager=manager %} | |||
| {% endfor %} | |||
| <p class="text-center"> | |||
| <a href="{% url "proposals:attach_study" proposal.pk %}">Voeg extra bestand toe | |||
There was a problem hiding this comment.
The kwarg should be study.pk. Leads to a bug otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch allows for the adding for extra attachments to a proposal and its studies.
An additional change to this branch is that we now allow changing the kind ("Type") of an attachment in the attachment update views.
Earlier I thought it would make sense to always enforce the kind if it was set by a slot. Now, when implementing extra files this felt like an overreach which would require deleting and re-adding of files by the user if they ever wanted to change the type.
Changing the type of a required attachment will simply move it from the required to an extra slot, as the attachment no longer fulfills the requirements for the required slot. Only if you are adding a new attachment to a required slot will the kind be enforced by the view.
I recommend taking a look at the changes to
Stepper.attachment_slots(), which is now a property that matches slots on the fly. Slots generated by checkers now live inStepper._attachment_slots, but that change should be of no consequence as long as theStepper.add_slot()method is used.