Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/silently run engines #28

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Feature/silently run engines #28

merged 4 commits into from
Mar 25, 2024

Conversation

ryan-kipawa
Copy link
Collaborator

It's nice to run engines without automatically printing all of the log files. This PR adds an option called "verbose" that is set to False by default.

@ryan-kipawa ryan-kipawa requested a review from wuwwen March 21, 2024 08:34
@wuwwen wuwwen merged commit 56d88f0 into main Mar 25, 2024
1 check passed
wuwwen added a commit that referenced this pull request Mar 28, 2024
* Pathlib + f-strings

* Revert "update"

This reverts commit 479bfa7.

* Update datatableaccess.py

Fix the issue of "Opening and closing a database in a loop takes increasingly long time"

* Correct the file path

Correct the file path

* Update README for 2024 experimental release.

* Update change log and version number

* Update name to MIKE+Py

* Remove license until official one is chosen.

* Add logo images.

* Update README with logo.

* Add LICENSE

* Update datatableaccess.py

Return if database is open

* Update links for new repo name.

* Update version number in pyproject.toml

* Add workflow to build docs

* Make a nicely introduction

* Add example notebook for running multiple rainfalls.

* Create full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Update full_test_2024_0.yml

* Example notebook for showing node connectivity information

* Notebook example of how to create a MIKE+ sqlite database

* Example of adding multiple section discharge result specifications

* Clarify meaning of GetDownstreamLinks / GetUpstreamLinks

* Feature/silently run engines (#28)

* Raise error instead of printing and return

* Add silent option for Engine1D

* Add silent option for both EPANET and SWMM

---------

Co-authored-by: wuwwen <wuw@dhigroup.com>

---------

Co-authored-by: Henrik Andersson <jan@dhigroup.com>
Co-authored-by: jue-hu <huj@dhigroup.com>
Co-authored-by: Ryan Murray <74630349+rywm-dhi@users.noreply.github.com>
@wuwwen wuwwen deleted the feature/silently_run_engines branch March 28, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants