Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move plot methods from Connector to root namespace #187

Merged
merged 19 commits into from
Jun 23, 2023

Conversation

jsmariegaard
Copy link
Member

@jsmariegaard jsmariegaard commented Apr 18, 2023

No description provided.

@jsmariegaard jsmariegaard marked this pull request as ready for review June 21, 2023 13:28
@jsmariegaard jsmariegaard requested a review from ecomodeller June 21, 2023 13:28
@jsmariegaard
Copy link
Member Author

@ecomodeller something happened here and I am not sure what. I updated from main - manually resolved - but still there are conflicts 😬

@ecomodeller
Copy link
Member

👀

@ecomodeller
Copy link
Member

Is plot_spatial coverage() the best name for this function?
Plot ✅
Spatial ✅
Coverage 🤔

image

@jsmariegaard
Copy link
Member Author

Is plot_spatial coverage() the best name for this function? Plot ✅ Spatial ✅ Coverage 🤔

image

😆 Good question -

I guess I like the "symmetry" of temporal and spatial coverage. And the idea is: how well do the observations cover the model in time and space.

What would you suggest?

@ecomodeller
Copy link
Member

I can't think of a better name, only think that coverage sounds rather quantitative.

@jsmariegaard
Copy link
Member Author

I can't think of a better name, only think that coverage sounds rather quantitative.

plot_spatial_overview() ?

@jsmariegaard jsmariegaard merged commit 716af5c into main Jun 23, 2023
@jsmariegaard jsmariegaard deleted the move-plot-coverage-methods branch June 23, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants