SkillTable is a collection of SkillArrays #309
Merged
+445
−390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecomodeller
reviewed
Dec 7, 2023
modelskill/skill.py
Outdated
| @@ -299,8 +313,18 @@ def __repr__(self): | |||
| def _repr_html_(self): | |||
| return self.df._repr_html_() | |||
|
|
|||
| def __getitem__(self, x): | |||
| return self.df[x] | |||
| def __getitem__(self, x) -> SkillArray | SkillFrame: | |||
There was a problem hiding this comment.
Use @overload to improve the auto-completion experience.
jsmariegaard
changed the title
jsmariegaard
changed the title
jsmariegaard
changed the title
|
This is first step in improving SkillTable. Replacing the data container to xr.Dataset is pushed to a subsequent PR (to minimize merge conflicts). |
ecomodeller
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each column of the SkillTable (formerly known as AggregatedSkill) is a SkillArray representing a single metric. Only SkillArray has a plotter.
Or shorter:
Soon the underlying datastructure will be a Dataset and a DataArray.