Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use observation weights in score #342

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Use observation weights in score #342

merged 4 commits into from
Dec 20, 2023

Conversation

ecomodeller
Copy link
Member

No description provided.

Copy link
Member

@jsmariegaard jsmariegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Search on attrs["weight"] and make sure always on Dataset (instead of DataArray)

@@ -549,7 +549,7 @@ def _plot_summary_table(
for ti in text_:
text_col_i = fig.text(x + dx, 0.6, ti, **txt_settings)
## Render, and get width
plt.draw()
# plt.draw() # TOOO this causes an error and I have no idea why it is here
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-caichac-DHI is this line important?

@jsmariegaard
Copy link
Member

@ecomodeller is this ready for review?

@jsmariegaard jsmariegaard self-requested a review December 20, 2023 09:14
@jsmariegaard jsmariegaard merged commit d963f17 into main Dec 20, 2023
10 checks passed
@jsmariegaard jsmariegaard deleted the weights branch December 20, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants