Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement band math endpoint #128

Merged
merged 19 commits into from
Mar 13, 2019
Merged

Implement band math endpoint #128

merged 19 commits into from
Mar 13, 2019

Conversation

dionhaefner
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #128 into master will increase coverage by 0.11%.
The diff coverage is 98.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   97.35%   97.47%   +0.11%     
==========================================
  Files          39       42       +3     
  Lines        1931     2095     +164     
  Branches      255      275      +20     
==========================================
+ Hits         1880     2042     +162     
- Misses         27       28       +1     
- Partials       24       25       +1
Impacted Files Coverage Δ
terracotta/server/keys.py 100% <100%> (ø) ⬆️
terracotta/server/rgb.py 96.22% <100%> (-0.07%) ⬇️
terracotta/server/datasets.py 100% <100%> (ø) ⬆️
terracotta/handlers/compute.py 100% <100%> (ø)
terracotta/server/compute.py 100% <100%> (ø)
terracotta/server/singleband.py 100% <100%> (ø) ⬆️
terracotta/scripts/connect.py 93.33% <100%> (ø) ⬆️
terracotta/server/colormap.py 97.29% <100%> (-0.14%) ⬇️
terracotta/server/metadata.py 100% <100%> (ø) ⬆️
terracotta/server/flask_api.py 89.39% <92.85%> (+0.5%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26ef2f6...cc3774b. Read the comment docs.

@dionhaefner
Copy link
Collaborator Author

@mrpgraae @j08lue @nmheim Could I ask one of you to take over from here? The feature is done from my perspective, but there are still some architectural decisions to be made (#20), the handler and flask route need test coverage, and the endpoint has to be documented.

@dionhaefner dionhaefner changed the title WIP: implement band math endpoint Implement band math endpoint Mar 7, 2019
@dionhaefner
Copy link
Collaborator Author

Done from my side. Needs more documentation, but so do all endpoints.

@dionhaefner dionhaefner merged commit 2ac1b4e into master Mar 13, 2019
@dionhaefner dionhaefner deleted the bandmath branch March 13, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants