Fix user and group determination #19
Conversation
There was a problem hiding this comment.
Looks good, I think!
Could not find the Popen line to suggest the modification from #18 (comment) though. Maybe that should be added, as you suggested!
|
I explicitly set |
Yeah, I do not know. If this was a full Linux system, there will be issues from not assigning supplemental groups. However, within docker, I do not expect issues to appear... |
|
Is there a race condition in the testing framework?! |
|
Anyway... there seem to be issues with dropping the extra groups in sagemaker afterall... in the commandline you can run: that list (not this literal one, of course!) should be the list of supplemental groups for the user. It is only available when the user actually exists. |
|
... Forgot that it also nicely lists the "groups=..." bit. However, could still be that sagemaker somehow needs access to group |
tests/test_models.py
Outdated
| [23746, *USER_GROUPS], | ||
| ), | ||
| # User does not exist, but is an int | ||
| ("23746", 23746, None, None, []), | ||
| (f"23746:{grp.getgrgid(0).gr_name}", 23746, 0, None, []), | ||
| (f"23746:{os.getgid()}", 23746, os.getgid(), None, []), | ||
| (f"23746:{grp.getgrgid(0).gr_name}", 23746, 0, None, [0]), | ||
| (f"23746:{os.getgid()}", 23746, os.getgid(), None, [os.getgid()]), | ||
| # User and group do not exist, but are ints | ||
| ("23746:23746", 23746, 23746, None, []), | ||
| ("23746:23746", 23746, 23746, None, [23746]), |
Closes #18