Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ildaeil: fix ImGui assertion error in debug builds #79

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

Simon-L
Copy link
Contributor

@Simon-L Simon-L commented Dec 10, 2021

Empty widgets labels generate IDs that conflict with the main window.

This fixes the assertion error with ImGui in debug builds:

Cardinal/src/DearImGui/imgui_widgets.cpp:632: bool ImGui::ButtonBehavior(const ImRect&, ImGuiID, bool*, bool*, ImGuiButtonFlags): Assertion mouse_button >= 0 && mouse_button < ImGuiMouseButton_COUNT' failed.

See ocornut/imgui#4796 which is precisely the same issue.
More info: https://github.com/ocornut/imgui/blob/master/docs/FAQ.md#q-how-can-i-have-widgets-with-an-empty-label

@falkTX
Copy link
Contributor

falkTX commented Dec 10, 2021

Thanks!

@falkTX falkTX merged commit c459ab9 into DISTRHO:main Dec 10, 2021
@Simon-L Simon-L deleted the fix-imgui-assert branch December 10, 2021 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants