-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLAP: add macro to use MIDI MPE dialect #443
base: develop
Are you sure you want to change the base?
Conversation
While I agree with the base idea, I think making this clap specific is wrong. |
1 similar comment
While I agree with the base idea, I think making this clap specific is wrong. |
also please make the PR target develop branch, not main. |
actually I think the best is to have default value as "undefined", where we do nothing special if unset. most plugin specs dont have a way to report this property anyhow |
a6e9147
to
45712ad
Compare
Thanks for the feedback! I rebased on develop and used a generic name for the macro -- maybe there is a better name for that ( |
7599a6e
to
52c2e78
Compare
59cc6ed
to
470c5b7
Compare
8507aec
to
7cd4819
Compare
This is related to #441
In the end I could not help but try a little something. At first I wanted to let people select any of the different dialects, but I was not sure how to properly retrieve the definitions in DPF (include the corresponding CLAP header or duplicate its
#define
somewhere? Neither seemed pretty). So I settled with just the "MPE" option for now, especially considering that the other dialects (MDI 2 or CLAP) might need to be properly parsed to reach the plugin.Then I started to add flags to let user configure MPE for input or output separately, to declare it as supported only (and not "preferred")... but that started to look bloated without other use cases.
Hence the trivial modification. I still hope that can be of some help. I tried my best to mimic how the flags are set. Tell me if I can improve something.