Use correct VST 3 directory name on PowerPC #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be ppc[64][le]-linux, depending on word size and endianness.
taylordotfish
force-pushed
the
vst3-ppc
branch
from
fd6eb6d to
c5f4f9b
Compare
|
I was thinking of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VST 3 specification declares that, on Linux, the name of the directory containing the plugin binary should begin with
uname -m, but Makefile.base.mk uses the output ofgcc -dumpmachine, which isn't always equivalent. In particular, this is the case for PowerPC—for example, on 64-bit little-endian PowerPC,uname -misppc64le, butgcc -dumpmachineispowerpc64le-linux-gnu, so the binary directory is incorrectly namedpowerpc64le-linuxrather thanppc64le-linux.This PR fixes the directory name on PowerPC, and also adds support for PowerPC in the CMake version, which currently errors.