Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev 26 loading warning improvements #34

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Conversation

lvoegtlin
Copy link
Contributor

Description

As described in #26 we improved the logging of the warning when loading a model. Now we just print the message if there are differences and we are loading something.

Additionally, we added better logging at the end of the program s.t. it prints not only the best task path but also the best backbone and header path.

How to Test/Run?

python run.py

@lvoegtlin lvoegtlin requested a review from powl7 August 30, 2021 13:27
@lvoegtlin lvoegtlin self-assigned this Aug 30, 2021
@lvoegtlin lvoegtlin added If time No rush at all Pipeline The general Hydra system labels Aug 30, 2021
@lvoegtlin lvoegtlin linked an issue Aug 30, 2021 that may be closed by this pull request
4 tasks
Copy link
Contributor

@powl7 powl7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@powl7 powl7 merged commit 5ec9125 into dev Aug 30, 2021
@powl7 powl7 deleted the dev_26_loading_warning_improvements branch August 30, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
If time No rush at all Pipeline The general Hydra system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loading model: show warning only when loading
2 participants