Dev shuffle data option #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
lvoegtlin
reviewed
Sep 16, 2021
Comment on lines
55
to
73
| if self.trainer.distributed_backend == 'ddp': | ||
| batch_size = self.trainer.datamodule.batch_size | ||
| if stage == 'fit': | ||
| num_samples = self.trainer.datamodule.his_train.num_samples | ||
| datasplit_name = 'train' | ||
| elif stage == 'test': | ||
| num_samples = self.trainer.datamodule.his_test.num_samples | ||
| datasplit_name = 'test' | ||
| else: | ||
| # unknown stage | ||
| log.warn(f'Unknown stage ({stage}) during setup!') | ||
| num_samples = -1 | ||
| datasplit_name = None | ||
|
|
||
| if num_samples % self.trainer.datamodule.batch_size != 0: | ||
| log.warn( | ||
| f'Number of sample ({num_samples}) in {datasplit_name} not dividable by batch size ({batch_size}).') | ||
| log.warn(f'Last batch will be incomplete. Behavior depends on datamodule.batch_drop_last setting.') | ||
|
|
There was a problem hiding this comment.
We could move it into the base_task but if we want to do that we have to name the datasets in a common fashion
… dataset inside the datamodule to test, train, and val
lvoegtlin
approved these changes
Sep 16, 2021
| num_samples = self.trainer.datamodule.his_train.num_samples | ||
| datasplit_name = 'train' | ||
| elif stage == 'test': | ||
| num_samples = self.trainer.datamodule.his_test.num_samples |
There was a problem hiding this comment.
use len(self.trainer.datamodule.his_train) instead of the num_samples field. Makes it more generic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to Test/Run?
python run.pySomething missing?
I don't think so