Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route): youtube playlistId #11739

Merged
merged 5 commits into from
Feb 1, 2023
Merged

fix(route): youtube playlistId #11739

merged 5 commits into from
Feb 1, 2023

Conversation

sohow
Copy link
Contributor

@sohow sohow commented Jan 31, 2023

该 PR 相关 Issue / Involved issue

Close #
#11576

完整路由地址 / Example for the proposed route(s)

/youtube/user/@tangshanlaowang

新 RSS 检查列表 / New RSS Script Checklist

  • 新的路由 New Route
  • 文档说明 Documentation
    • 中文文档 CN
    • 英文文档 EN
  • 全文获取 fulltext
    • 使用缓存 Use Cache
  • 反爬/频率限制 anti-bot or rate limit?
    • 如果有, 是否有对应的措施? If yes, do your code reflect this sign?
  • 日期和时间 date and time
    • 可以解析 Parsed
    • 时区调整 Correct TimeZone
  • 添加了新的包 New package added
  • Puppeteer

说明 / Note

fix youtube user rss bug

@github-actions github-actions bot added Route: v2 v2 route related Auto: Route Test Complete Auto route test has finished on given PR labels Jan 31, 2023
@github-actions
Copy link
Contributor

Successfully generated as following:

http://localhost:1200/youtube/user/tangshanlaowang - Failed
HTTPError: Response code 404 (Not Found)

Route requested: /user/tangshanlaowang
Error message: YouTube RSS is disabled due to the lack of <a href="https://docs.rsshub.app/install/#pei-zhi-bu-fen-rss-mo-kuai-pei-zhi">relevant config</a>
Helpful Information to provide when opening issue:
Path: /user/tangshanlaowang
Node version: v16.19.0
Git Hash: 4851534

@sohow sohow changed the title fix youtube playlistId fix(router): youtube playlistId Jan 31, 2023
@sohow sohow changed the title fix(router): youtube playlistId fix(route): youtube playlistId Jan 31, 2023
Copy link
Collaborator

@TonyRL TonyRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update ctx.state.data as well

        title: `${channelName || username} - YouTube`,
        link: channelName ? `https://www.youtube.com/${username}` : `https://www.youtube.com/user/${username}`,

lib/v2/youtube/user.js Outdated Show resolved Hide resolved
lib/v2/youtube/user.js Outdated Show resolved Hide resolved
sohow and others added 3 commits February 1, 2023 10:38
Co-authored-by: Tony <TonyRL@users.noreply.github.com>
Co-authored-by: Tony <TonyRL@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Successfully generated as following:

http://localhost:1200/youtube/user/tangshanlaowang - Failed
HTTPError: Response code 404 (Not Found)

Route requested: /user/tangshanlaowang
Error message: YouTube RSS is disabled due to the lack of <a href="https://docs.rsshub.app/install/#pei-zhi-bu-fen-rss-mo-kuai-pei-zhi">relevant config</a>
Helpful Information to provide when opening issue:
Path: /user/tangshanlaowang
Node version: v16.19.0
Git Hash: f4d5f80

Copy link
Contributor Author

@sohow sohow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add "@username"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Successfully generated as following:

http://localhost:1200/youtube/user/tangshanlaowang - Failed
HTTPError: Response code 404 (Not Found)

Route requested: /user/tangshanlaowang
Error message: YouTube RSS is disabled due to the lack of <a href="https://docs.rsshub.app/install/#pei-zhi-bu-fen-rss-mo-kuai-pei-zhi">relevant config</a>
Helpful Information to provide when opening issue:
Path: /user/tangshanlaowang
Node version: v16.19.0
Git Hash: 1bdb754

@sohow
Copy link
Contributor Author

sohow commented Feb 1, 2023

github-actions bot

Copy link
Contributor Author

@sohow sohow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github-actions bot

@TonyRL TonyRL merged commit 4e8a3bb into DIYgod:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto: Route Test Complete Auto route test has finished on given PR Route: v2 v2 route related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants