chore: bump golangci-lint to v1.50.0

I had to do several things: - contextcheck now supports Go 1.18 generics, but I had to disable it because of this kkHAIKE/contextcheck#9 - dupword produces to many false positives, so it's also disabled - revive found all packages which didn't have a documentation comment before. And tehre is A LOT of them. I updated some of them, but gave up at some point and just added them to exclude rules for now. - change lint-vulncheck to use `base` stage as base Signed-off-by: Dmitriy Matrenichev <dmitry.matrenichev@siderolabs.com>
DJAlPee · May 22, 2023 · 063950e · 063950e
1 parent decab2d
commit 063950e
Show file tree

Hide file tree

Showing 83 changed files with 339 additions and 25 deletions.
diff --git a/.golangci.yml b/.golangci.yml
@@ -167,6 +167,8 @@ linters:
     - typecheck
     - varnamelen # too annoying
     - wrapcheck
+    - contextcheck # enable once golangci-lint 1.50.1 or 1.51 lands
+    - dupword # too annoying
 
     # abandoned linters for which golangci shows the warning that the repo is archived by the owner
     - golint
@@ -196,6 +198,238 @@ issues:
     - path: internal/app/machined/pkg/system/services
       linters:
         - dupl
+    - path: cmd/installer/pkg/qemuimg
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/cmd/mgmt
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/cmd/mgmt/inject
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/cmd/talos
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/pkg/talos/action
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/pkg/talos/global
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: cmd/talosctl/pkg/talos/helpers
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/controllers/cri
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/controllers/kubeaccess/serviceaccount
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/controllers/perf
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/events
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/health
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/runner/containerd
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/runner/goroutine
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/runner/process
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system/runner/restart
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/machined/pkg/system
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/maintenance
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/maintenance/server
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/poweroff
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/trustd/internal/reg
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/app/trustd
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/containers/image
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/etcd
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/install
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/mount
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/mount/switchroot
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: internal/pkg/tui/components
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/argsbuilder
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/chunker
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/chunker/file
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/chunker/stream
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/download
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/grpc/dialer
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/grpc/factory
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/grpc/gen
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/grpc/middleware/auth/basic
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/grpc/middleware/authz
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/kubernetes
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/kubernetes/inject
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/provision/providers
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: pkg/provision/providers/qemu
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/encoder
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/kubespan
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: client/config
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/merge
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/types/v1alpha1/bundle
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/cri
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/runtime
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: kernel
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: constants
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/perf
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/cluster
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: role
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: resources/hardware
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/decoder
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/internal/cis
+      text: "should have a package comment"
+      linters:
+        - revive
+    - path: config/types/v1alpha1/machine
+      text: "should have a package comment"
+      linters:
+        - revive
 
     # pkg/machinery module
     - path: config/types/v1alpha1

diff --git a/Dockerfile b/Dockerfile
@@ -300,7 +300,7 @@ WORKDIR /src
 
 # The vulncheck target runs the vulnerability check tool.
 
-FROM build-go AS lint-vulncheck
+FROM base AS lint-vulncheck
 RUN --mount=type=cache,target=/.cache govulncheck ./...
 
 # The init target builds the init binary.

diff --git a/Makefile b/Makefile
@@ -18,8 +18,8 @@ PKGS ?= v1.3.0-alpha.0-29-g91e73b3
 EXTRAS ?= v1.3.0-alpha.0-1-g8f00d77
 GO_VERSION ?= 1.19
 GOIMPORTS_VERSION ?= v0.1.11
-GOFUMPT_VERSION ?= v0.3.0
-GOLANGCILINT_VERSION ?= v1.48.0
+GOFUMPT_VERSION ?= v0.4.0
+GOLANGCILINT_VERSION ?= v1.50.0
 STRINGER_VERSION ?= v0.1.12
 ENUMER_VERSION ?= v1.1.2
 DEEPCOPY_GEN_VERSION ?= v0.21.3

diff --git a/cmd/installer/cmd/root.go b/cmd/installer/cmd/root.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package cmd implements the installer command.
 package cmd
 
 import (

diff --git a/cmd/installer/main.go b/cmd/installer/main.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package installer provides the installer implementation.
 package main
 
 import "github.com/talos-systems/talos/cmd/installer/cmd"

diff --git a/cmd/installer/pkg/epoch.go b/cmd/installer/pkg/epoch.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package pkg contains the installer cmd logic.
 package pkg
 
 import (

diff --git a/cmd/installer/pkg/install/extensions.go b/cmd/installer/pkg/install/extensions.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package install provides the installation routine.
 package install
 
 import (

diff --git a/cmd/installer/pkg/install/manifest.go b/cmd/installer/pkg/install/manifest.go
@@ -212,6 +212,7 @@ func (m *Manifest) checkMounts(device Device) error {
 				}
 
 				if !device.SkipOverlayMountsCheck && fields[len(fields)-2] == "overlay" {
+					//nolint:dupword
 					// parsing options (last column) in the overlay mount line which looks like:
 					// 163 70 0:52 /apid / ro,relatime - overlay overlay rw,lowerdir=/opt,upperdir=/var/system/overlays/opt-diff,workdir=/var/system/overlays/opt-workdir
 

diff --git a/cmd/installer/pkg/ova/ova.go b/cmd/installer/pkg/ova/ova.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package ova implements OVA creation.
 package ova
 
 import (

diff --git a/cmd/talosctl/cmd/docs.go b/cmd/talosctl/cmd/docs.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package cmd provides the talosctl command implementation.
 package cmd
 
 import (
@@ -98,7 +99,7 @@ var docsCmd = &cobra.Command{
 	},
 }
 
-// GenMarkdownReference is the the same as GenMarkdownTree, but
+// GenMarkdownReference is the same as GenMarkdownTree, but
 // with custom filePrepender and linkHandler.
 func GenMarkdownReference(cmd *cobra.Command, w io.Writer, linkHandler func(string) string) error {
 	for _, c := range cmd.Commands() {

diff --git a/cmd/talosctl/cmd/mgmt/gen/ca.go b/cmd/talosctl/cmd/mgmt/gen/ca.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package gen implements the genration of various artifacts.
 package gen
 
 import (

diff --git a/cmd/talosctl/cmd/talos/pcap.go b/cmd/talosctl/cmd/talos/pcap.go
@@ -159,6 +159,8 @@ func dumpPackets(r io.Reader) error {
 //	{ 0x30, 0, 0, 0x00000000 },
 //	{ 0x54, 0, 0, 0x000000f0 },
 //	{ 0x15, 0, 8, 0x00000060 },
+//
+//nolint:dupword
 func parseBPFInstructions(in string) ([]*machine.BPFInstruction, error) {
 	in = strings.TrimSpace(in)
 

diff --git a/cmd/talosctl/main.go b/cmd/talosctl/main.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package talosctl provides the talosctl utility implementation.
 package main
 
 import (

diff --git a/cmd/talosctl/pkg/mgmt/helpers/artifacts.go b/cmd/talosctl/pkg/mgmt/helpers/artifacts.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package helpers provides helpers for talosctl.
 package helpers
 
 import (

diff --git a/cmd/talosctl/pkg/talos/global/client.go b/cmd/talosctl/pkg/talos/global/client.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package global provides global flags for talosctl.
 package global
 
 import (

diff --git a/cmd/talosctl/pkg/talos/helpers/mode.go b/cmd/talosctl/pkg/talos/helpers/mode.go
@@ -20,7 +20,7 @@ import (
 // Should be never passed to the API.
 const InteractiveMode machine.ApplyConfigurationRequest_Mode = -1
 
-// Mode apply, patch, edit config config update mode.
+// Mode apply, patch, edit config update mode.
 type Mode struct {
 	options     map[string]machine.ApplyConfigurationRequest_Mode
 	Mode        machine.ApplyConfigurationRequest_Mode

diff --git a/internal/app/apid/main.go b/internal/app/apid/main.go
@@ -2,6 +2,7 @@
 // License, v. 2.0. If a copy of the MPL was not distributed with this
 // file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+// Package apid implements apid functionality.
 package apid
 
 import (

diff --git a/internal/app/apid/pkg/director/local_address.go b/internal/app/apid/pkg/director/local_address.go
@@ -28,7 +28,7 @@ type localAddressProvider struct {
 }
 
 // NewLocalAddressProvider initializes and returns a new LocalAddressProvider.
-func NewLocalAddressProvider(st state.State) (*localAddressProvider, error) {
+func NewLocalAddressProvider(st state.State) (LocalAddressProvider, error) {
 	p := &localAddressProvider{}
 
 	evCh := make(chan state.Event)