Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if we failed to send an MQTT message #97

Merged
merged 1 commit into from
Nov 14, 2021

Conversation

aparshin
Copy link
Contributor

Fixes #94 . MqttMessagingService throws an CouldNotSendMqttMessageException if MQTTNet's MQTTClient returns an error.

Unfortunately, I couldn't test it properly because looks like MQTT onboarding responses in the repo are invalid (at least the only MQTT test GivenValidCapabilitiesWhenSendingCapabilitiesMessageThenTheAgrirouterShouldSetTheCapabilities fails).

Copy link
Member

@saschadoemer saschadoemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ᕦ( ͡° ͜ʖ ͡°)ᕤ

@saschadoemer saschadoemer merged commit 88f95fd into DKE-Data:main Nov 14, 2021
oliverrahner pushed a commit that referenced this pull request Nov 15, 2021
* Throw exception if we failed to send an MQTT message (#97)

* Add standard system exception handling.

Co-authored-by: Alexander Parshin <parshin.alexander@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MqttMessagingService doesn't check that MQTT messages are successfully sent to agrirouter
2 participants