Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruff (no formatter) #325

Merged
merged 22 commits into from
Mar 26, 2024
Merged

Ruff (no formatter) #325

merged 22 commits into from
Mar 26, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Feb 6, 2024 •
edited
Loading

Use ruff over flake8.

This swaps out flake8 for ruff.

@Cadair Cadair added the No Changelog Entry Needed This pull request does not need a changelog entry label Feb 6, 2024
nabobalis
nabobalis reviewed Feb 6, 2024
View reviewed changes
.ruff.toml Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.74%. Comparing base (c6dd4c2) to head (a3e736d).

❗ Current head a3e736d differs from pull request most recent head 0ba3eb9. Consider uploading reports for the commit 0ba3eb9 to get more accurate results

Files Patch % Lines
dkist/dataset/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #325       +/-   ##
===========================================
+ Coverage   37.99%   97.74%   +59.74%     
===========================================
  Files          51       34       -17     
  Lines        2832     1993      -839     
===========================================
+ Hits         1076     1948      +872     
+ Misses       1756       45     -1711

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair changed the title Ruff Ruff (no formatter) Mar 6, 2024
@Cadair Cadair force-pushed the ruff branch 2 times, most recently from f27a6ad to 55cae34 Compare March 6, 2024 11:15
@Cadair
Copy link
Member Author

Cadair commented Mar 22, 2024

pre-commit.ci autofix

@Cadair Cadair marked this pull request as ready for review March 22, 2024 10:54
@Cadair Cadair requested a review from SolarDrew March 22, 2024 10:54
SolarDrew
SolarDrew approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@SolarDrew SolarDrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👍 I look forward to resolving conflicts for the rest of the year.

@Cadair
Copy link
Member Author

Cadair commented Mar 22, 2024

Let's hold off merging this until #344 lands.

@Cadair Cadair enabled auto-merge (squash) March 26, 2024 11:12
@Cadair Cadair disabled auto-merge March 26, 2024 11:12
@Cadair
Copy link
Member Author

Cadair commented Mar 26, 2024

pre-commit.ci autofix

@Cadair Cadair enabled auto-merge (squash) March 26, 2024 11:13
@Cadair Cadair merged commit 3faa8d3 into DKISTDC:main Mar 26, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis left review comments

@SolarDrew SolarDrew SolarDrew approved these changes

Assignees
No one assigned
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cadair @nabobalis @SolarDrew