Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gwcs version check in test #346

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Conversation

braingram
Copy link
Contributor

gwcs 0.21.0 was released.

I believe this may be interfering with a version check in the test_read_wcs_with_backwards_affine test.

The check was previously updated in:
#313
and added in:
#305
which mentions the draft gwcs PR:
spacetelescope/gwcs#457
which might be what this test is attempting to check against. @Cadair can you confirm?

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (38b6829) to head (f662fe8).

❗ Current head f662fe8 differs from pull request most recent head abbe041. Consider uploading reports for the commit abbe041 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   97.73%   97.68%   -0.06%     
==========================================
  Files          34       34              
  Lines        1990     1990              
==========================================
- Hits         1945     1944       -1     
- Misses         45       46       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair added the No Changelog Entry Needed This pull request does not need a changelog entry label Mar 19, 2024
@Cadair Cadair merged commit 24d71fd into DKISTDC:main Mar 19, 2024
13 checks passed
@Cadair
Copy link
Member

Cadair commented Mar 19, 2024

Thanks @braingram 🙏

@braingram braingram deleted the bump_test_skip branch March 19, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Entry Needed This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants