Add smart pointer tracker #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicmue
added a commit
to everestsystems/get-size
that referenced
this pull request
Oct 26, 2023
Adds the enhancements proposed by: - DKerp/get-size#11 - DKerp/get-size#13 Also adds support for `uuid`, `dashmap` and `serde_json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
trackerparameter to theget_sizeandget_heap_sizemethods.It allows tracking the address of already counted smart pointers and thereby eliminates the need to manage that yourself.
This is the same feature that already exists in https://github.com/wasmerio/loupe.
I also implemented
GetSizefor some serde_json and indexmap and some more std types.I understand that these are somewhat opinionated changes, that's why I haven't updated the docs, yet.
Please let me know if you want to merge it, then I can update the docs as well.