Skip to content

Commit

Permalink
Disable stringop-overflow GCC warning temporarily.
Browse files Browse the repository at this point in the history
  • Loading branch information
holke committed Jun 3, 2022
1 parent 5ec76e4 commit 2fcf081
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/t8_cmesh/t8_cmesh_partition.c
Original file line number Diff line number Diff line change
Expand Up @@ -2525,8 +2525,21 @@ t8_cmesh_partition_given (t8_cmesh_t cmesh, const struct t8_cmesh *cmesh_from,
t8_cmesh_partition_recvloop (cmesh, cmesh_from, tree_offset, my_buffer,
my_buffer_bytes, comm, fr, lr);
if (num_send_mpi > 0) {
/* The newer GCC compiler warn when using specific
* MPI calls, this behavious is known by the MPI community
* and will get fixed in future versions: https://github.com/pmodels/mpich/issues/5687
* It is safe to ignore the warning, and since our CI requires
* runs with -Werror to pass, we need to disable the warning
* temporarily. */
#ifdef __GNUC__
#ifndef __clang__
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wstringop-overflow"
mpiret = sc_MPI_Waitall (num_request_alloc, requests,
sc_MPI_STATUSES_IGNORE);
#pragma GCC diagnostic push

This comment has been minimized.

Copy link
@cburstedde

cburstedde Sep 19, 2022

Collaborator

Should this not be GCC diagnostic pop?

This comment has been minimized.

Copy link
@holke

holke Sep 19, 2022

Author Collaborator

yes it should be, thanks.
Can you point to the version/branch where you found this?
Since i currently cannot locate these lines in the repository.

This comment has been minimized.

Copy link
@cburstedde

cburstedde Sep 19, 2022

Collaborator

It may be you fixed it a long time ago, and this code got superseded.

#endif
#endif
SC_CHECK_MPI (mpiret);
}

Expand Down

0 comments on commit 2fcf081

Please sign in to comment.