Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more stringent formatting #10

Merged
merged 5 commits into from
Jul 3, 2024
Merged

add more stringent formatting #10

merged 5 commits into from
Jul 3, 2024

Conversation

wucke13
Copy link
Collaborator

@wucke13 wucke13 commented Jun 27, 2024

Pull Request Overview

This pull request fixes formatting, in the form of being more strict especially on md and yaml files

Testing Strategy

nix flake check

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran nix fmt
  • Ran nix flake check

Author

Signed-off-by: wucke13 wucke13@gmail.com

Copy link
Collaborator

@nerodesu017 nerodesu017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, don't have experience with nix, nix fmt. Have to wait for Alex' review

@wucke13
Copy link
Collaborator Author

wucke13 commented Jul 3, 2024

@valexandru I'd like to get this through ASAP. Any comments or suggestions on how to do this differently would be highly appreciated :)

@valexandru
Copy link
Collaborator

I assume that this is mostly for the md and yaml files, as cargo fmt already takes care of the syntax on rust files. Otherwise, looks good.

@nerodesu017 nerodesu017 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 61cc3a2 Jul 3, 2024
4 checks passed
@wucke13 wucke13 deleted the dev/wucke13 branch August 15, 2024 08:36
george-cosma added a commit that referenced this pull request Nov 19, 2024
george-cosma added a commit that referenced this pull request Nov 19, 2024
Signed-off-by: George Cosma <georgemagic10@gmail.com>
george-cosma added a commit that referenced this pull request Nov 19, 2024
Signed-off-by: George Cosma <georgemagic10@gmail.com>
george-cosma added a commit that referenced this pull request Nov 19, 2024
Signed-off-by: George Cosma <georgemagic10@gmail.com>
george-cosma added a commit that referenced this pull request Nov 19, 2024
Signed-off-by: George Cosma <george.cosma@oxidos.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants