Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/global testsuite #108

Closed
wants to merge 3 commits into from
Closed

Fix/global testsuite #108

wants to merge 3 commits into from

Conversation

george-cosma
Copy link
Collaborator

Pull Request Overview

This pull request adds/changes/fixes...

Testing Strategy

This pull request was tested by...

TODO or Help Wanted

This pull request still needs...

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt

Github Issue

This pull request closes <GITHUB_ISSUE>

nerodesu017 and others added 3 commits December 10, 2024 14:48
Signed-off-by: nerodesu017 <adrian.popescu@oxidos.io>

Signed-off-by: nerodesu017 <adrian.popescu@oxidos.io>
Signed-off-by: nerodesu017 <adrian.popescu@oxidos.io>
Signed-off-by: George Cosma <george.cosma@oxidos.io>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 73.15914% with 226 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/core/error.rs 1.72% 57 Missing ⚠️
src/validation/code.rs 68.61% 16 Missing and 27 partials ⚠️
src/execution/value.rs 64.63% 29 Missing ⚠️
src/core/reader/types/mod.rs 58.69% 18 Missing and 1 partial ⚠️
src/execution/interpreter_loop.rs 90.82% 16 Missing and 3 partials ⚠️
src/core/reader/types/element.rs 82.29% 7 Missing and 10 partials ⚠️
src/execution/mod.rs 89.36% 8 Missing and 2 partials ⚠️
src/core/reader/types/data.rs 25.00% 4 Missing and 2 partials ⚠️
src/execution/store.rs 66.66% 6 Missing ⚠️
src/validation/validation_stack.rs 77.77% 5 Missing and 1 partial ⚠️
... and 4 more
Files with missing lines Coverage Δ
src/validation/globals.rs 94.44% <100.00%> (-5.56%) ⬇️
src/validation/mod.rs 78.47% <100.00%> (-2.55%) ⬇️
src/core/reader/types/import.rs 26.31% <0.00%> (-7.90%) ⬇️
src/execution/const_interpreter_loop.rs 50.63% <83.33%> (+14.26%) ⬆️
src/execution/value_stack.rs 82.81% <76.47%> (-0.98%) ⬇️
src/validation/read_constant_expression.rs 61.53% <66.66%> (-9.90%) ⬇️
src/core/reader/types/data.rs 17.00% <25.00%> (+1.04%) ⬆️
src/execution/store.rs 81.81% <66.66%> (-18.19%) ⬇️
src/validation/validation_stack.rs 91.11% <77.77%> (-0.99%) ⬇️
src/execution/mod.rs 90.47% <89.36%> (+0.71%) ⬆️
... and 6 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants