Implementation + Tests for i32.div_s and i32.div_u. Runtime Errors #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
execution
validation
tests
examples
priority-high
priority-medium
priority-low
feature
labels
nerodesu017
changed the title
george-cosma
reviewed
Jul 2, 2024
george-cosma
approved these changes
Jul 3, 2024
wucke13
approved these changes
Jul 3, 2024
valexandru
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request:
i32.div_soperationi32.div_soperationi32.div_uoperationi32.div_uoperationinvoke_funcandfunctionfunctions to be able to return an error through the Result return type - to add runtime errorsTesting Strategy
This pull request was tested locally on the added test case and all others.
TODO or Help Wanted
This pull request still needs a review.
Formatting
cargo fmtcargo checkcargo buildGithub Issue
This pull request partially implements #2
Author
Signed-off-by: Popescu Adrian adrian.popescu@oxidos.io