Update doc: SB3-Contrib #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGleave
reviewed
Dec 21, 2020
| @@ -408,6 +408,82 @@ def test_save_load_policy(tmp_path, model_class, policy_str): | |||
| os.remove(tmp_path / "actor.pkl") | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("model_class", [DQN]) | |||
There was a problem hiding this comment.
Why do we have this as a parameter when we only set it to one value? Upgrade potential?
There was a problem hiding this comment.
hmm, I wrote that test when I found the bug reviewing QR-DQN PR on the contrib repo.
So, I think my idea was that QR-DQN will be part of SB3 main repo at some point, hence the parameter ;).
Co-authored-by: Adam Gleave <adam@gleave.me>
thanks for the suggestions =) (I will update SB3 contrib readme too afterward) |
liuyuqi123
added a commit
to liuyuqi123/stable-baselines3
that referenced
this pull request
Dec 29, 2020
Update doc: SB3-Contrib (DLR-RM#267)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update doc to mention sb3-contrib and update internal variable names to match the one discussed in Stable-Baselines-Team/stable-baselines3-contrib#13.
I also fixed a minor bug when saving DQN q-network alone.
Motivation and Context
Types of changes
Checklist:
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line