Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added method get_distribution for class ActorCriticPolicy #564

Closed
wants to merge 4 commits into from

Conversation

cyprienc
Copy link
Contributor

Description

New method get_distribution for class ActorCriticPolicy returning current action distribution given observations

Motivation and Context

This is related to Stable-Baselines-Team/stable-baselines3-contrib#40 (comment)
TRPO will require the Distribution of the current policy.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

New method get_distribution for class ActorCriticPolicy returning current action distribution given observations
- adding block for Release 1.2.1a0
- adding cyprienc to contributors
Changing version from 1.2.0 to 1.2.1a0

New Features:
^^^^^^^^^^^^^
- Added method `get_distribution` for `ActorCriticPolicy` (@cyprienc)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Added method `get_distribution` for `ActorCriticPolicy` (@cyprienc)
- Added method `get_distribution` for ``ActorCriticPolicy`` (@cyprienc)

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a test is missing, otherwise LGTM ;)

@araffin
Copy link
Member

araffin commented Sep 13, 2021

I added the test and fixed the changelog in #566
but I couldn't push the changes to your PR because you were using master branch... so I opened another PR.

@cyprienc
Copy link
Contributor Author

Ok - thanks a lot - I am closing this one then

@cyprienc cyprienc closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants