Skip to content

Commit

Permalink
moveit_controller_manager.launch: pass execution_type via pass_all_ar…
Browse files Browse the repository at this point in the history
…gs (moveit#2928)

While we need to pass execution_type to fake_moveit_controller_manager.launch,
the controller_manager.launch files of real-robot shouldn't be required
to define this argument. However, if they don't roslaunch fails with an
`unused args` exception (see moveit#2786).
Passing arguments via pass_all_args should solve that issue.
  • Loading branch information
rhaschke authored Oct 22, 2021
1 parent a2a2961 commit 61d18f2
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

<!-- Load the robot specific controller manager; this sets the moveit_controller_manager ROS parameter -->
<arg name="moveit_controller_manager" default="[ROBOT_NAME]" />
<include file="$(dirname)/$(arg moveit_controller_manager)_moveit_controller_manager.launch.xml">
<arg name="execution_type" value="$(arg execution_type)" />
</include>
<!-- We use pass_all_args=true here to pass execution_type, which is required by fake controllers, but not by real-robot controllers.
As real-robot controller_manager.launch files shouldn't be required to define this argument, we use the trick of passing all args. -->
<include file="$(dirname)/$(arg moveit_controller_manager)_moveit_controller_manager.launch.xml" pass_all_args="true" />

</launch>

0 comments on commit 61d18f2

Please sign in to comment.