Refactor atomic revisions

Use `revision.create_revision(atomic=True)` instead of explicity
wrapping with ``transaction.atomic`

judge/social_auth.py

@@ -5,7 +5,6 @@
 
 from django import forms
 from django.contrib.auth.models import User
-from django.db import transaction
 from django.http import HttpResponseRedirect
 from django.shortcuts import render
 from django.urls import reverse
@@ -92,7 +91,7 @@ def make_profile(backend, user, response, is_new=False, *args, **kwargs):
             logger.info(data)
             form = ProfileForm(data, instance=user.profile, user=user)
             if form.is_valid():
-                with transaction.atomic(), revisions.create_revision():
+                with revisions.create_revision(atomic=True):
                     form.save()
                     revisions.set_user(user)
                     revisions.set_comment('Updated on registration')

judge/views/comment.py

@@ -1,7 +1,7 @@
 from django.contrib.auth.decorators import login_required
 from django.contrib.auth.mixins import LoginRequiredMixin, PermissionRequiredMixin
 from django.core.exceptions import PermissionDenied
-from django.db import IntegrityError, transaction
+from django.db import IntegrityError
 from django.db.models import F
 from django.forms.models import ModelForm
 from django.http import Http404, HttpResponse, HttpResponseBadRequest, HttpResponseForbidden
@@ -125,7 +125,7 @@ class CommentEditAjax(LoginRequiredMixin, CommentMixin, UpdateView):
     form_class = CommentEditForm
 
     def form_valid(self, form):
-        with transaction.atomic(), revisions.create_revision():
+        with revisions.create_revision(atomic=True):
             revisions.set_comment(_('Edited from site'))
             revisions.set_user(self.request.user)
             return super(CommentEditAjax, self).form_valid(form)

judge/views/contests.py

@@ -11,7 +11,7 @@
 from django.contrib.auth.mixins import LoginRequiredMixin, PermissionRequiredMixin
 from django.core.cache import cache
 from django.core.exceptions import ImproperlyConfigured, ObjectDoesNotExist
-from django.db import IntegrityError, transaction
+from django.db import IntegrityError
 from django.db.models import Case, Count, F, FloatField, IntegerField, Max, Min, Q, Sum, Value, When
 from django.db.models.expressions import CombinedExpression
 from django.http import Http404, HttpResponse, HttpResponseBadRequest, HttpResponseRedirect
@@ -261,7 +261,7 @@ def form_valid(self, form):
         contest.user_count = 0
         contest.locked_after = None
         contest.key = form.cleaned_data['key']
-        with transaction.atomic(), revisions.create_revision():
+        with revisions.create_revision(atomic=True):
             contest.save()
             contest.tags.set(tags)
             contest.organizations.set(organizations)

judge/views/organization.py

@@ -5,7 +5,6 @@
 from django.core.cache import cache
 from django.core.cache.utils import make_template_fragment_key
 from django.core.exceptions import PermissionDenied
-from django.db import transaction
 from django.db.models import Count, Q
 from django.forms import Form, modelformset_factory
 from django.http import Http404, HttpResponsePermanentRedirect, HttpResponseRedirect
@@ -294,7 +293,7 @@ def get_form(self, form_class=None):
         return form
 
     def form_valid(self, form):
-        with transaction.atomic(), revisions.create_revision():
+        with revisions.create_revision(atomic=True):
             revisions.set_comment(_('Edited from site'))
             revisions.set_user(self.request.user)
             return super(EditOrganization, self).form_valid(form)

judge/views/problem.py

@@ -704,7 +704,7 @@ def form_valid(self, form):
         problem.ac_rate = 0
         problem.user_count = 0
         problem.code = form.cleaned_data['code']
-        with transaction.atomic(), revisions.create_revision():
+        with revisions.create_revision(atomic=True):
             problem.save()
             problem.authors.add(self.request.profile)
             problem.allowed_languages.set(languages)

judge/views/user.py

@@ -13,7 +13,6 @@
 from django.contrib.contenttypes.models import ContentType
 from django.core.cache import cache
 from django.core.exceptions import PermissionDenied, ValidationError
-from django.db import transaction
 from django.db.models import Count, Max, Min
 from django.db.models.fields import DateField
 from django.db.models.functions import Cast, ExtractYear
@@ -361,7 +360,7 @@ def edit_profile(request):
     if request.method == 'POST':
         form = ProfileForm(request.POST, instance=request.profile, user=request.user)
         if form.is_valid():
-            with transaction.atomic(), revisions.create_revision():
+            with revisions.create_revision(atomic=True):
                 form.save()
                 revisions.set_user(request.user)
                 revisions.set_comment(_('Updated on site'))
@@ -410,7 +409,7 @@ def edit_profile(request):
 @login_required
 def generate_api_token(request):
     profile = request.profile
-    with transaction.atomic(), revisions.create_revision():
+    with revisions.create_revision(atomic=True):
         revisions.set_user(request.user)
         revisions.set_comment(_('Generated API token for user'))
         return JsonResponse({'data': {'token': profile.generate_api_token()}})
@@ -420,7 +419,7 @@ def generate_api_token(request):
 @login_required
 def remove_api_token(request):
     profile = request.profile
-    with transaction.atomic(), revisions.create_revision():
+    with revisions.create_revision(atomic=True):
         profile.api_token = None
         profile.save()
         revisions.set_user(request.user)
@@ -432,7 +431,7 @@ def remove_api_token(request):
 @login_required
 def generate_scratch_codes(request):
     profile = request.profile
-    with transaction.atomic(), revisions.create_revision():
+    with revisions.create_revision(atomic=True):
         revisions.set_user(request.user)
         revisions.set_comment(_('Generated scratch codes for user'))
     return JsonResponse({'data': {'codes': profile.generate_scratch_codes()}})