allow users to see own participation after window

To provide a better UX, especially for fully-hidden contests, contestants can now see their own participation after they have completed the contest.
DMOJ · Feb 22, 2022 · 7c05b2f · 7c05b2f
1 parent cf34cf6
commit 7c05b2f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/judge/models/contest.py b/judge/models/contest.py
@@ -203,7 +203,7 @@ def can_see_own_scoreboard(self, user):
             return True
         if not self.can_join:
             return False
-        if not self.show_scoreboard and not self.is_in_contest(user):
+        if not self.show_scoreboard and not self.is_in_contest(user) and not self.has_completed_contest(user):
             return False
         return True
 

diff --git a/judge/models/tests/test_contest.py b/judge/models/tests/test_contest.py
@@ -391,7 +391,7 @@ def test_contest_hidden_scoreboard_contest_methods(self):
                 'has_completed_contest': self.assertFalse,
             },
             'normal_after_window': {
-                'can_see_own_scoreboard': self.assertFalse,
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertFalse,
                 'has_completed_contest': self.assertTrue,
             },
@@ -461,24 +461,31 @@ def test_visible_scoreboard_contest_methods(self):
     def test_full_hidden_scoreboard_contest_methods(self):
         data = {
             'superuser': {
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertTrue,
             },
             'non_staff_tester': {
+                'can_see_own_scoreboard': self.assertFalse,
                 'can_see_full_scoreboard': self.assertFalse,
             },
             'non_staff_author': {
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertTrue,
             },
             'staff_contest_edit_own': {
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertTrue,
             },
             'staff_contest_edit_all': {
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertTrue,
             },
             'normal': {
+                'can_see_own_scoreboard': self.assertFalse,
                 'can_see_full_scoreboard': self.assertFalse,
             },
             'normal_after_window': {
+                'can_see_own_scoreboard': self.assertTrue,
                 'can_see_full_scoreboard': self.assertFalse,
             },
         }