Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch prerequisites to site data interface #1890

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

Riolku
Copy link
Contributor

@Riolku Riolku commented Mar 8, 2022

In conjunction with DMOJ/judge-server#1013.

Here are results locally. Generator takes no arguments and always outputs the same case for convenience.

image
image

Essentially I copied all the code from generator args for the UI and made sure it works.

Although it's not an issue to merge this before the judge PR, it's rather nonsensical.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (19e7a09) 46.84% compared to head (139b157) 46.82%.

Files Patch % Lines
judge/utils/problem_data.py 0.00% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
- Coverage   46.84%   46.82%   -0.03%     
==========================================
  Files         250      251       +1     
  Lines       13275    13293      +18     
==========================================
+ Hits         6219     6224       +5     
- Misses       7056     7069      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Riolku Riolku marked this pull request as draft March 11, 2022 05:39
@Riolku
Copy link
Contributor Author

Riolku commented Mar 11, 2022

I want to merge DMOJ/judge-server#1019 first.

@Riolku Riolku force-pushed the site-batch-prereqs branch 3 times, most recently from 3449d61 to 777448d Compare March 11, 2022 18:50
@Riolku Riolku marked this pull request as ready for review March 11, 2022 18:51
@Riolku
Copy link
Contributor Author

Riolku commented Mar 11, 2022

The field was renamed to dependencies, so it has been accordingly updated.

Copy link
Member

@Ninjaclasher Ninjaclasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will assume the UI changes are sane, LGTM once you rebase

judge/migrations/0132_site_data_batch_prerequisites.py Outdated Show resolved Hide resolved
@Riolku Riolku force-pushed the site-batch-prereqs branch 2 times, most recently from 1ad6b65 to 898fe1e Compare January 6, 2024 04:33
@Riolku Riolku force-pushed the site-batch-prereqs branch from 898fe1e to 139b157 Compare January 6, 2024 04:37
Copy link
Member

@kiritofeng kiritofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiritofeng kiritofeng added this pull request to the merge queue Jan 21, 2024
Merged via the queue into DMOJ:master with commit 435839e Jan 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants